diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2022-08-25 04:53:39 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-25 04:53:39 (GMT) |
| commit | f51216df073310c783f1890993fe9b67ccb3c6b4 (patch) | |
| tree | c3198119e01414dc165d5d86a29ad2dca87ed36e /Lib/unittest/test | |
| parent | 915ee9ed43b199de6f9fb371c2224ef4593522ab (diff) | |
| download | cpython-f51216df073310c783f1890993fe9b67ccb3c6b4.zip cpython-f51216df073310c783f1890993fe9b67ccb3c6b4.tar.gz cpython-f51216df073310c783f1890993fe9b67ccb3c6b4.tar.bz2 | |
gh-96021: Explicitly close the IsolatedAsyncioTestCase runner in tests (GH-96135)
Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed
in __del__. It makes tests depending on the GC an unreliable on other
implementations. It is better to close the runner explicitly even if
currently there is no a public API for this.
(cherry picked from commit 4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Diffstat (limited to 'Lib/unittest/test')
| -rw-r--r-- | Lib/unittest/test/test_async_case.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/Lib/unittest/test/test_async_case.py b/Lib/unittest/test/test_async_case.py index f59fc76..d7d4dc9 100644 --- a/Lib/unittest/test/test_async_case.py +++ b/Lib/unittest/test/test_async_case.py @@ -43,10 +43,10 @@ VAR = contextvars.ContextVar('VAR', default=()) class TestAsyncCase(unittest.TestCase): maxDiff = None - def tearDown(self): + def setUp(self): # Ensure that IsolatedAsyncioTestCase instances are destroyed before # starting a new event loop - support.gc_collect() + self.addCleanup(support.gc_collect) def test_full_cycle(self): class Test(unittest.IsolatedAsyncioTestCase): @@ -151,6 +151,7 @@ class TestAsyncCase(unittest.TestCase): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioRunner) try: test.debug() except MyException: @@ -186,6 +187,7 @@ class TestAsyncCase(unittest.TestCase): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioRunner) try: test.debug() except MyException: @@ -221,6 +223,7 @@ class TestAsyncCase(unittest.TestCase): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioRunner) try: test.debug() except MyException: @@ -262,6 +265,7 @@ class TestAsyncCase(unittest.TestCase): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioRunner) try: test.debug() except MyException: @@ -424,6 +428,7 @@ class TestAsyncCase(unittest.TestCase): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioRunner) try: test.debug() except MyException: |