summaryrefslogtreecommitdiffstats
path: root/Lib/unittest
diff options
context:
space:
mode:
authorBerker Peksag <berker.peksag@gmail.com>2016-03-27 21:30:40 (GMT)
committerBerker Peksag <berker.peksag@gmail.com>2016-03-27 21:30:40 (GMT)
commit5a6c018b57d3c9fa9ac67809f5745d88971d5aca (patch)
tree2d3178f6fd97125f6f2849ffa9e06f618dd8f625 /Lib/unittest
parentf841909f092e4c7e17f1673cc7f0d9b535542a60 (diff)
parentce913877e42b7fa03434c2e765ace891e0f5c4dc (diff)
downloadcpython-5a6c018b57d3c9fa9ac67809f5745d88971d5aca.zip
cpython-5a6c018b57d3c9fa9ac67809f5745d88971d5aca.tar.gz
cpython-5a6c018b57d3c9fa9ac67809f5745d88971d5aca.tar.bz2
Issue #25195: Fix a regression in mock.MagicMock
_Call is a subclass of tuple (changeset 3603bae63c13 only works for classes) so we need to implement __ne__ ourselves. Patch by Andrew Plummer.
Diffstat (limited to 'Lib/unittest')
-rw-r--r--Lib/unittest/mock.py3
-rw-r--r--Lib/unittest/test/testmock/testmock.py17
2 files changed, 20 insertions, 0 deletions
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
index 50ff949..7400fb7 100644
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -2047,6 +2047,9 @@ class _Call(tuple):
return (other_args, other_kwargs) == (self_args, self_kwargs)
+ __ne__ = object.__ne__
+
+
def __call__(self, *args, **kwargs):
if self.name is None:
return _Call(('', args, kwargs), name='()')
diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py
index b2d9acb..526eeab 100644
--- a/Lib/unittest/test/testmock/testmock.py
+++ b/Lib/unittest/test/testmock/testmock.py
@@ -304,6 +304,17 @@ class MockTest(unittest.TestCase):
# an exception. See issue 24857.
self.assertFalse(mock.call_args == "a long sequence")
+
+ def test_calls_equal_with_any(self):
+ call1 = mock.call(mock.MagicMock())
+ call2 = mock.call(mock.ANY)
+
+ # Check that equality and non-equality is consistent even when
+ # comparing with mock.ANY
+ self.assertTrue(call1 == call2)
+ self.assertFalse(call1 != call2)
+
+
def test_assert_called_with(self):
mock = Mock()
mock()
@@ -319,6 +330,12 @@ class MockTest(unittest.TestCase):
mock.assert_called_with(1, 2, 3, a='fish', b='nothing')
+ def test_assert_called_with_any(self):
+ m = MagicMock()
+ m(MagicMock())
+ m.assert_called_with(mock.ANY)
+
+
def test_assert_called_with_function_spec(self):
def f(a, b, c, d=None):
pass