diff options
| author | Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> | 2020-01-29 15:43:37 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-29 15:43:37 (GMT) |
| commit | a327677905956ae0b239ff430a1346dfe265709e (patch) | |
| tree | 761a01408b75c8900ca38b7cc86e0a49a50b27bb /Lib/unittest | |
| parent | 3cb49b62e61208efcefbc04414e769fc173f205d (diff) | |
| download | cpython-a327677905956ae0b239ff430a1346dfe265709e.zip cpython-a327677905956ae0b239ff430a1346dfe265709e.tar.gz cpython-a327677905956ae0b239ff430a1346dfe265709e.tar.bz2 | |
bpo-39485: fix corner-case in method-detection of mock (GH-18252)
Replace check for whether something is a method in the mock module. The
previous version fails on PyPy, because there no method wrappers exist
(everything looks like a regular Python-defined function). Thus the
isinstance(getattr(result, '__get__', None), MethodWrapperTypes) check
returns True for any descriptor, not just methods.
This condition could also return erroneously True in CPython for
C-defined descriptors.
Instead to decide whether something is a method, just check directly
whether it's a function defined on the class. This passes all tests on
CPython and fixes the bug on PyPy.
Diffstat (limited to 'Lib/unittest')
| -rw-r--r-- | Lib/unittest/mock.py | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py index a3d8b6e..37ea5c7 100644 --- a/Lib/unittest/mock.py +++ b/Lib/unittest/mock.py @@ -2748,7 +2748,7 @@ def _must_skip(spec, entry, is_type): continue if isinstance(result, (staticmethod, classmethod)): return False - elif isinstance(getattr(result, '__get__', None), MethodWrapperTypes): + elif isinstance(result, FunctionTypes): # Normal method => skip if looked up on type # (if looked up on instance, self is already skipped) return is_type @@ -2778,10 +2778,6 @@ FunctionTypes = ( type(ANY.__eq__), ) -MethodWrapperTypes = ( - type(ANY.__eq__.__get__), -) - file_spec = None |