diff options
author | Xtreak <tir.karthi@gmail.com> | 2019-02-25 21:46:34 (GMT) |
---|---|---|
committer | Chris Withers <chris@withers.org> | 2019-02-25 21:46:34 (GMT) |
commit | 9c3f284de598550be6687964c23fd7599e53b20e (patch) | |
tree | a873c7a0f55f9a1d2c3fdf00476e7bd24563e1cd /Lib/unittest | |
parent | f1b9abe35f75393351b3d954a392122a3f8f6951 (diff) | |
download | cpython-9c3f284de598550be6687964c23fd7599e53b20e.zip cpython-9c3f284de598550be6687964c23fd7599e53b20e.tar.gz cpython-9c3f284de598550be6687964c23fd7599e53b20e.tar.bz2 |
Autospec functions should propagate mock calls to parent GH-11273
Diffstat (limited to 'Lib/unittest')
-rw-r--r-- | Lib/unittest/mock.py | 8 | ||||
-rw-r--r-- | Lib/unittest/test/testmock/testmock.py | 13 |
2 files changed, 21 insertions, 0 deletions
diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py index ccbcd35..2ccf0d8 100644 --- a/Lib/unittest/mock.py +++ b/Lib/unittest/mock.py @@ -321,6 +321,14 @@ class _CallList(list): def _check_and_set_parent(parent, value, name, new_name): + # function passed to create_autospec will have mock + # attribute attached to which parent must be set + if isinstance(value, FunctionTypes): + try: + value = value.mock + except AttributeError: + pass + if not _is_instance_mock(value): return False if ((value._mock_name or value._mock_new_name) or diff --git a/Lib/unittest/test/testmock/testmock.py b/Lib/unittest/test/testmock/testmock.py index 04ab522..2ad90ea 100644 --- a/Lib/unittest/test/testmock/testmock.py +++ b/Lib/unittest/test/testmock/testmock.py @@ -1830,5 +1830,18 @@ class MockTest(unittest.TestCase): self.assertEqual(type(call.parent().parent), _Call) + def test_parent_propagation_with_create_autospec(self): + + def foo(a, b): + pass + + mock = Mock() + mock.child = create_autospec(foo) + mock.child(1, 2) + + self.assertRaises(TypeError, mock.child, 1) + self.assertEqual(mock.mock_calls, [call.child(1, 2)]) + + if __name__ == '__main__': unittest.main() |