diff options
| author | Martin Panter <vadmium+py@gmail.com> | 2016-04-30 01:03:40 (GMT) |
|---|---|---|
| committer | Martin Panter <vadmium+py@gmail.com> | 2016-04-30 01:03:40 (GMT) |
| commit | aa27982ffca6ebfaad0a776e93e98a30e95b8b88 (patch) | |
| tree | 64d9c45f8e0f7904056029a0bc92f51ebdb731b0 /Lib/urllib/request.py | |
| parent | 6d34bbbfc7ac1a5a8d518ed1b767239de26650c5 (diff) | |
| download | cpython-aa27982ffca6ebfaad0a776e93e98a30e95b8b88.zip cpython-aa27982ffca6ebfaad0a776e93e98a30e95b8b88.tar.gz cpython-aa27982ffca6ebfaad0a776e93e98a30e95b8b88.tar.bz2 | |
Issue #26864: Fix case insensitivity and suffix comparison with no_proxy
Patch by Xiang Zhang.
Diffstat (limited to 'Lib/urllib/request.py')
| -rw-r--r-- | Lib/urllib/request.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index fc42d49..b28cd60 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -2432,8 +2432,12 @@ def proxy_bypass_environment(host, proxies=None): # check if the host ends with any of the DNS suffixes no_proxy_list = [proxy.strip() for proxy in no_proxy.split(',')] for name in no_proxy_list: - if name and (hostonly.endswith(name) or host.endswith(name)): - return 1 + if name: + name = re.escape(name) + pattern = r'(.+\.)?%s$' % name + if (re.match(pattern, hostonly, re.I) + or re.match(pattern, host, re.I)): + return 1 # otherwise, don't bypass return 0 |