diff options
author | Walter Dörwald <walter@livinglogic.de> | 2002-06-03 15:58:32 (GMT) |
---|---|---|
committer | Walter Dörwald <walter@livinglogic.de> | 2002-06-03 15:58:32 (GMT) |
commit | 65230a2de758fbde57b3893c402436ae0202ada3 (patch) | |
tree | 4b0b8431990125dd567b23c4ad3325959dc91a2e /Lib/urllib2.py | |
parent | a401ae4010eeb385a0775c505637bbc332bc184c (diff) | |
download | cpython-65230a2de758fbde57b3893c402436ae0202ada3.zip cpython-65230a2de758fbde57b3893c402436ae0202ada3.tar.gz cpython-65230a2de758fbde57b3893c402436ae0202ada3.tar.bz2 |
Remove uses of the string and types modules:
x in string.whitespace => x.isspace()
type(x) in types.StringTypes => isinstance(x, basestring)
isinstance(x, types.StringTypes) => isinstance(x, basestring)
type(x) is types.StringType => isinstance(x, str)
type(x) == types.StringType => isinstance(x, str)
string.split(x, ...) => x.split(...)
string.join(x, y) => y.join(x)
string.zfill(x, ...) => x.zfill(...)
string.count(x, ...) => x.count(...)
hasattr(types, "UnicodeType") => try: unicode except NameError:
type(x) != types.TupleTuple => not isinstance(x, tuple)
isinstance(x, types.TupleType) => isinstance(x, tuple)
type(x) is types.IntType => isinstance(x, int)
Do not mention the string module in the rlcompleter docstring.
This partially applies SF patch http://www.python.org/sf/562373
(with basestring instead of string). (It excludes the changes to
unittest.py and does not change the os.stat stuff.)
Diffstat (limited to 'Lib/urllib2.py')
-rw-r--r-- | Lib/urllib2.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/Lib/urllib2.py b/Lib/urllib2.py index 898da7d..814a2df 100644 --- a/Lib/urllib2.py +++ b/Lib/urllib2.py @@ -92,7 +92,6 @@ import httplib import inspect import re import base64 -import types import urlparse import md5 import mimetypes @@ -303,7 +302,7 @@ class OpenerDirector: def open(self, fullurl, data=None): # accept a URL or a Request object - if isinstance(fullurl, types.StringTypes): + if isinstance(fullurl, basestring): req = Request(fullurl, data) else: req = fullurl @@ -516,7 +515,7 @@ class HTTPPasswordMgr: def add_password(self, realm, uri, user, passwd): # uri could be a single URI or a sequence - if isinstance(uri, types.StringTypes): + if isinstance(uri, basestring): uri = [uri] uri = tuple(map(self.reduce_uri, uri)) if not realm in self.passwd: @@ -1084,7 +1083,7 @@ if __name__ == "__main__": install_opener(build_opener(cfh, GopherHandler)) for url in urls: - if isinstance(url, types.TupleType): + if isinstance(url, tuple): url, req = url else: req = None |