summaryrefslogtreecommitdiffstats
path: root/Lib/urllib
diff options
context:
space:
mode:
authorXiang Zhang <angwerzx@126.com>2017-01-09 03:47:55 (GMT)
committerXiang Zhang <angwerzx@126.com>2017-01-09 03:47:55 (GMT)
commit959ff7f1c6412fe768a29ffe1d355f126dc9e80c (patch)
treefcdf0ada43bebc1074162f12683ffed169a701f4 /Lib/urllib
parent8cbd46f19ffa8b1ac7220fcd1c791ab4cade8e10 (diff)
downloadcpython-959ff7f1c6412fe768a29ffe1d355f126dc9e80c.zip
cpython-959ff7f1c6412fe768a29ffe1d355f126dc9e80c.tar.gz
cpython-959ff7f1c6412fe768a29ffe1d355f126dc9e80c.tar.bz2
Issue #29142: Fix suffixes in no_proxy handling in urllib.
In urllib.request, suffixes in no_proxy environment variable with leading dots could match related hostnames again (e.g. .b.c matches a.b.c). Patch by Milan Oberkirch.
Diffstat (limited to 'Lib/urllib')
-rw-r--r--Lib/urllib/request.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index a4bf97d..a46c689 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -2450,6 +2450,7 @@ def proxy_bypass_environment(host, proxies=None):
no_proxy_list = [proxy.strip() for proxy in no_proxy.split(',')]
for name in no_proxy_list:
if name:
+ name = name.lstrip('.') # ignore leading dots
name = re.escape(name)
pattern = r'(.+\.)?%s$' % name
if (re.match(pattern, hostonly, re.I)