diff options
| author | Victor Stinner <victor.stinner@haypocalc.com> | 2011-06-17 12:01:18 (GMT) |
|---|---|---|
| committer | Victor Stinner <victor.stinner@haypocalc.com> | 2011-06-17 12:01:18 (GMT) |
| commit | a4c45d73cf6eeb8ede6ee701c0372d7e45dc24f2 (patch) | |
| tree | c7bee889bda36c5418ff802a662d10b2f0efa61e /Lib/urllib | |
| parent | 0f83b1511c76e892b48b16d656cceb032bdb9cb3 (diff) | |
| download | cpython-a4c45d73cf6eeb8ede6ee701c0372d7e45dc24f2.zip cpython-a4c45d73cf6eeb8ede6ee701c0372d7e45dc24f2.tar.gz cpython-a4c45d73cf6eeb8ede6ee701c0372d7e45dc24f2.tar.bz2 | |
Issue #12133: fix a ResourceWarning in urllib.request
AbstractHTTPHandler.do_open() of urllib.request closes the HTTP connection if
its getresponse() method fails with a socket error. Patch written by Ezio
Melotti.
Diffstat (limited to 'Lib/urllib')
| -rw-r--r-- | Lib/urllib/request.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index 5325d62..35fd1f1 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -1137,6 +1137,8 @@ class AbstractHTTPHandler(BaseHandler): r = h.getresponse() # an HTTPResponse instance except socket.error as err: raise URLError(err) + finally: + h.close() r.url = req.get_full_url() # This line replaces the .msg attribute of the HTTPResponse |