diff options
author | Brian Curtin <brian.curtin@gmail.com> | 2010-11-05 14:56:16 (GMT) |
---|---|---|
committer | Brian Curtin <brian.curtin@gmail.com> | 2010-11-05 14:56:16 (GMT) |
commit | be80ab4b83f5b50eaba36bd6f7a09f8cb1f68c6a (patch) | |
tree | aac2332756d18e448e2295b1a4e63ac07c70d41a /Lib/uuid.py | |
parent | fc3901e5bf1026393faa44924d0fcaa498bef997 (diff) | |
download | cpython-be80ab4b83f5b50eaba36bd6f7a09f8cb1f68c6a.zip cpython-be80ab4b83f5b50eaba36bd6f7a09f8cb1f68c6a.tar.gz cpython-be80ab4b83f5b50eaba36bd6f7a09f8cb1f68c6a.tar.bz2 |
Merged revisions 86192 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r86192 | brian.curtin | 2010-11-05 09:48:35 -0500 (Fri, 05 Nov 2010) | 3 lines
Shift the pipe-using code into an else block, then close the pipe
in finally. Removes two ResourceWarnings.
........
Diffstat (limited to 'Lib/uuid.py')
-rw-r--r-- | Lib/uuid.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/Lib/uuid.py b/Lib/uuid.py index 4f8d539..fdd0c5c 100644 --- a/Lib/uuid.py +++ b/Lib/uuid.py @@ -353,10 +353,13 @@ def _ipconfig_getnode(): pipe = os.popen(os.path.join(dir, 'ipconfig') + ' /all') except IOError: continue - for line in pipe: - value = line.split(':')[-1].strip().lower() - if re.match('([0-9a-f][0-9a-f]-){5}[0-9a-f][0-9a-f]', value): - return int(value.replace('-', ''), 16) + else: + for line in pipe: + value = line.split(':')[-1].strip().lower() + if re.match('([0-9a-f][0-9a-f]-){5}[0-9a-f][0-9a-f]', value): + return int(value.replace('-', ''), 16) + finally: + pipe.close() def _netbios_getnode(): """Get the hardware address on Windows using NetBIOS calls. |