diff options
| author | Victor Stinner <vstinner@redhat.com> | 2018-12-10 10:12:53 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-10 10:12:53 (GMT) |
| commit | 8e0418688906206fe59bd26344320c0fc026849e (patch) | |
| tree | fcea9643fe407349cfc21aa9acdeace4c3afc264 /Lib/xml/dom | |
| parent | 6fef0f1a8162e755f3b46677265b7cf052d9b83f (diff) | |
| download | cpython-8e0418688906206fe59bd26344320c0fc026849e.zip cpython-8e0418688906206fe59bd26344320c0fc026849e.tar.gz cpython-8e0418688906206fe59bd26344320c0fc026849e.tar.bz2 | |
bpo-35052: Fix handler on xml.dom.minidom.cloneNode() (GH-11061)
Fix xml.dom.minidom cloneNode() on a document with an entity: pass
the correct arguments to the user data handler of an entity (fix an
old copy/paste mistake).
Bug spotted and fix proposed by Charalampos Stratakis, initial
reproducer written by Petr Viktorin.
Co-Authored-By: Charalampos Stratakis <cstratak@redhat.com>
Co-Authored-By: Petr Viktorin <encukou@gmail.com>
Diffstat (limited to 'Lib/xml/dom')
| -rw-r--r-- | Lib/xml/dom/minidom.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py index 469c517..43569dd 100644 --- a/Lib/xml/dom/minidom.py +++ b/Lib/xml/dom/minidom.py @@ -1318,7 +1318,7 @@ class DocumentType(Identified, Childless, Node): entity.encoding = e.encoding entity.version = e.version clone.entities._seq.append(entity) - e._call_user_data_handler(operation, n, entity) + e._call_user_data_handler(operation, e, entity) self._call_user_data_handler(operation, self, clone) return clone else: @@ -1921,7 +1921,7 @@ def _clone_node(node, deep, newOwnerDocument): entity.ownerDocument = newOwnerDocument clone.entities._seq.append(entity) if hasattr(e, '_call_user_data_handler'): - e._call_user_data_handler(operation, n, entity) + e._call_user_data_handler(operation, e, entity) else: # Note the cloning of Document and DocumentType nodes is # implementation specific. minidom handles those cases |