diff options
author | Tim Peters <tim.peters@gmail.com> | 2002-07-18 14:54:28 (GMT) |
---|---|---|
committer | Tim Peters <tim.peters@gmail.com> | 2002-07-18 14:54:28 (GMT) |
commit | 30d489651101ef9f34cad4124b404371a2eeef72 (patch) | |
tree | c7989c606a72df152f43596f5c47a95ca35ca075 /Lib | |
parent | 32616cf8ec7d930024c0031ab7f951d8247bf2fa (diff) | |
download | cpython-30d489651101ef9f34cad4124b404371a2eeef72.zip cpython-30d489651101ef9f34cad4124b404371a2eeef72.tar.gz cpython-30d489651101ef9f34cad4124b404371a2eeef72.tar.bz2 |
Gave hotshot.LogReader a close() method, to allow users to close the
file object that LogReader opens. Used it then in test_hotshot; the
test passes again on Windows. Thank Guido for the analysis.
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/hotshot/log.py | 3 | ||||
-rw-r--r-- | Lib/test/test_hotshot.py | 5 |
2 files changed, 4 insertions, 4 deletions
diff --git a/Lib/hotshot/log.py b/Lib/hotshot/log.py index 335fff9..9084461 100644 --- a/Lib/hotshot/log.py +++ b/Lib/hotshot/log.py @@ -51,6 +51,9 @@ class LogReader: self._append = self._stack.append self._pop = self._stack.pop + def close(self): + self._reader.close() + def addinfo(self, key, value): """This method is called for each additional ADD_INFO record. diff --git a/Lib/test/test_hotshot.py b/Lib/test/test_hotshot.py index db3c914..2a45a7f 100644 --- a/Lib/test/test_hotshot.py +++ b/Lib/test/test_hotshot.py @@ -31,10 +31,7 @@ class UnlinkingLogReader(hotshot.log.LogReader): try: return hotshot.log.LogReader.next(self) except (IndexError, StopIteration): - # XXX This fails on Windows because the named file is still - # XXX open. Offhand I couldn't find an appropriate way to close - # XXX the file object, or even where the heck it is. LogReader - # XXX in particular doesn't have a close() method. + self.close() os.unlink(self.__logfn) raise |