summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSenthil Kumaran <senthil@uthcode.com>2011-10-19 16:52:24 (GMT)
committerSenthil Kumaran <senthil@uthcode.com>2011-10-19 16:52:24 (GMT)
commit59a06d412d3a130c770faa1fc8d8fe13b0a67d3c (patch)
treeae6c0f206036e6aef6a3171a26881c5bea95c0f1 /Lib
parent1e87da16eac24f6e0fb6908906ab6400ce583fa0 (diff)
downloadcpython-59a06d412d3a130c770faa1fc8d8fe13b0a67d3c.zip
cpython-59a06d412d3a130c770faa1fc8d8fe13b0a67d3c.tar.gz
cpython-59a06d412d3a130c770faa1fc8d8fe13b0a67d3c.tar.bz2
Fix closes Issue12529 - cgi.parse_header failure on double quotes and
semicolons. Patch by Ben Darnell and Petri Lehtinen.
Diffstat (limited to 'Lib')
-rwxr-xr-xLib/cgi.py2
-rw-r--r--Lib/test/test_cgi.py3
2 files changed, 4 insertions, 1 deletions
diff --git a/Lib/cgi.py b/Lib/cgi.py
index b4c620a..e7cd778 100755
--- a/Lib/cgi.py
+++ b/Lib/cgi.py
@@ -293,7 +293,7 @@ def _parseparam(s):
while s[:1] == ';':
s = s[1:]
end = s.find(';')
- while end > 0 and s.count('"', 0, end) % 2:
+ while end > 0 and (s.count('"', 0, end) - s.count('\\"', 0, end)) % 2:
end = s.find(';', end + 1)
if end < 0:
end = len(s)
diff --git a/Lib/test/test_cgi.py b/Lib/test/test_cgi.py
index e282a51..63547b2 100644
--- a/Lib/test/test_cgi.py
+++ b/Lib/test/test_cgi.py
@@ -377,6 +377,9 @@ this is the content of the fake file
self.assertEqual(
cgi.parse_header('attachment; filename="strange;name";size=123;'),
("attachment", {"filename": "strange;name", "size": "123"}))
+ self.assertEqual(
+ cgi.parse_header('form-data; name="files"; filename="fo\\"o;bar"'),
+ ("form-data", {"name": "files", "filename": 'fo"o;bar'}))
def test_main():