diff options
author | R. David Murray <rdmurray@bitdance.com> | 2009-05-07 16:27:02 (GMT) |
---|---|---|
committer | R. David Murray <rdmurray@bitdance.com> | 2009-05-07 16:27:02 (GMT) |
commit | 8fd522fb5f45aa05252c32063dc9c624f2e788b3 (patch) | |
tree | d59e2fe8b9ca033acae8fd5a7835a1681407e0d0 /Lib | |
parent | 02588111254fb02f703d762e5990544852bd9965 (diff) | |
download | cpython-8fd522fb5f45aa05252c32063dc9c624f2e788b3.zip cpython-8fd522fb5f45aa05252c32063dc9c624f2e788b3.tar.gz cpython-8fd522fb5f45aa05252c32063dc9c624f2e788b3.tar.bz2 |
Issue5955: aifc's close method did not close the file it wrapped,
now it does. This also means getfp method now returns the real fp.
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/aifc.py | 7 | ||||
-rw-r--r-- | Lib/test/test_aifc.py | 15 |
2 files changed, 19 insertions, 3 deletions
diff --git a/Lib/aifc.py b/Lib/aifc.py index 197e755..b4123ca 100644 --- a/Lib/aifc.py +++ b/Lib/aifc.py @@ -282,10 +282,11 @@ class Aifc_read: self._convert = None self._markers = [] self._soundpos = 0 - self._file = Chunk(file) - if self._file.getname() != 'FORM': + self._file = file + chunk = Chunk(file) + if chunk.getname() != 'FORM': raise Error, 'file does not start with FORM id' - formdata = self._file.read(4) + formdata = chunk.read(4) if formdata == 'AIFF': self._aifc = 0 elif formdata == 'AIFC': diff --git a/Lib/test/test_aifc.py b/Lib/test/test_aifc.py index 0aed908..54694ea 100644 --- a/Lib/test/test_aifc.py +++ b/Lib/test/test_aifc.py @@ -91,6 +91,21 @@ class AIFCTest(unittest.TestCase): # XXX: this test fails, not sure if it should succeed or not # self.assertEqual(f.readframes(5), fout.readframes(5)) + def test_close(self): + class Wrapfile(object): + def __init__(self, file): + self.file = open(file) + self.closed = False + def close(self): + self.file.close() + self.closed = True + def __getattr__(self, attr): return getattr(self.file, attr) + testfile = Wrapfile(self.sndfilepath) + f = self.f = aifc.open(testfile) + self.assertEqual(testfile.closed, False) + f.close() + self.assertEqual(testfile.closed, True) + def test_main(): run_unittest(AIFCTest) |