diff options
author | Samuel Colvin <samcolvin@gmail.com> | 2019-10-13 11:45:36 (GMT) |
---|---|---|
committer | Serhiy Storchaka <storchaka@gmail.com> | 2019-10-13 11:45:36 (GMT) |
commit | 793cb85437299a3da3d74fe65480d720af330cbb (patch) | |
tree | af1f297dba6baeb54bdb6838e840f79604d39b6d /Lib | |
parent | 140a7d1f3579e778656a6b6bfad72489e9870a4d (diff) | |
download | cpython-793cb85437299a3da3d74fe65480d720af330cbb.zip cpython-793cb85437299a3da3d74fe65480d720af330cbb.tar.gz cpython-793cb85437299a3da3d74fe65480d720af330cbb.tar.bz2 |
bpo-38431: Fix __repr__ method of InitVar to work with typing objects. (GH-16702)
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/dataclasses.py | 7 | ||||
-rw-r--r-- | Lib/test/test_dataclasses.py | 2 |
2 files changed, 8 insertions, 1 deletions
diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py index 9135b07..91c1f6f 100644 --- a/Lib/dataclasses.py +++ b/Lib/dataclasses.py @@ -206,7 +206,12 @@ class InitVar: self.type = type def __repr__(self): - return f'dataclasses.InitVar[{self.type.__name__}]' + if isinstance(self.type, type): + type_name = self.type.__name__ + else: + # typing objects, e.g. List[int] + type_name = repr(self.type) + return f'dataclasses.InitVar[{type_name}]' def __class_getitem__(cls, type): return InitVar(type) diff --git a/Lib/test/test_dataclasses.py b/Lib/test/test_dataclasses.py index 037bf4c..238335e 100644 --- a/Lib/test/test_dataclasses.py +++ b/Lib/test/test_dataclasses.py @@ -1102,6 +1102,8 @@ class TestCase(unittest.TestCase): # Make sure the repr is correct. self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]') + self.assertEqual(repr(InitVar[List[int]]), + 'dataclasses.InitVar[typing.List[int]]') def test_init_var_inheritance(self): # Note that this deliberately tests that a dataclass need not |