summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2015-11-30 15:35:40 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2015-11-30 15:35:40 (GMT)
commitb63015b01a07c535ef4c26fe0bc4c336295dd08e (patch)
treefb928a9e06f9d272f98c5d16dc594332dc8e6621 /Lib
parent3c49710e9fc383c521817cee3cb5d3695430b7ea (diff)
parentcbbec1c53f4b6fb88b4ae984e69db2d2951cd560 (diff)
downloadcpython-b63015b01a07c535ef4c26fe0bc4c336295dd08e.zip
cpython-b63015b01a07c535ef4c26fe0bc4c336295dd08e.tar.gz
cpython-b63015b01a07c535ef4c26fe0bc4c336295dd08e.tar.bz2
Issue #25718: Fixed copying object with state with boolean value is false.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/copy.py4
-rw-r--r--Lib/test/test_copy.py9
2 files changed, 11 insertions, 2 deletions
diff --git a/Lib/copy.py b/Lib/copy.py
index 3a45fdf..493c487 100644
--- a/Lib/copy.py
+++ b/Lib/copy.py
@@ -279,7 +279,7 @@ def _reconstruct(x, info, deep, memo=None):
if n > 2:
state = info[2]
else:
- state = {}
+ state = None
if n > 3:
listiter = info[3]
else:
@@ -293,7 +293,7 @@ def _reconstruct(x, info, deep, memo=None):
y = callable(*args)
memo[id(x)] = y
- if state:
+ if state is not None:
if deep:
state = deepcopy(state, memo)
if hasattr(y, '__setstate__'):
diff --git a/Lib/test/test_copy.py b/Lib/test/test_copy.py
index b9eaddd..4107e8a 100644
--- a/Lib/test/test_copy.py
+++ b/Lib/test/test_copy.py
@@ -213,6 +213,9 @@ class TestCopy(unittest.TestCase):
return self.foo == other.foo
x = C(42)
self.assertEqual(copy.copy(x), x)
+ # State with boolean value is false (issue #25718)
+ x = C(0.0)
+ self.assertEqual(copy.copy(x), x)
# The deepcopy() method
@@ -517,6 +520,12 @@ class TestCopy(unittest.TestCase):
self.assertEqual(y, x)
self.assertIsNot(y, x)
self.assertIsNot(y.foo, x.foo)
+ # State with boolean value is false (issue #25718)
+ x = C([])
+ y = copy.deepcopy(x)
+ self.assertEqual(y, x)
+ self.assertIsNot(y, x)
+ self.assertIsNot(y.foo, x.foo)
def test_deepcopy_reflexive_inst(self):
class C: