summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorRichard Oudkerk <shibturn@gmail.com>2012-06-06 18:04:57 (GMT)
committerRichard Oudkerk <shibturn@gmail.com>2012-06-06 18:04:57 (GMT)
commite41682b9945091c2e4b95a3f6a4582944fd7598e (patch)
tree00cc5480b7e07b0677ae22141f99be675945aaaa /Lib
parenta3a164a03c78d66539f4fe9abf8d1dd5c08babaa (diff)
downloadcpython-e41682b9945091c2e4b95a3f6a4582944fd7598e.zip
cpython-e41682b9945091c2e4b95a3f6a4582944fd7598e.tar.gz
cpython-e41682b9945091c2e4b95a3f6a4582944fd7598e.tar.bz2
Issue #12157: pool.map() does not handle empty iterable correctly
Initial patch by mouad
Diffstat (limited to 'Lib')
-rw-r--r--Lib/multiprocessing/pool.py1
-rw-r--r--Lib/test/test_multiprocessing.py18
2 files changed, 16 insertions, 3 deletions
diff --git a/Lib/multiprocessing/pool.py b/Lib/multiprocessing/pool.py
index 0c29e64..ccee961 100644
--- a/Lib/multiprocessing/pool.py
+++ b/Lib/multiprocessing/pool.py
@@ -584,6 +584,7 @@ class MapResult(ApplyResult):
if chunksize <= 0:
self._number_left = 0
self._ready = True
+ del cache[self._job]
else:
self._number_left = length//chunksize + bool(length % chunksize)
diff --git a/Lib/test/test_multiprocessing.py b/Lib/test/test_multiprocessing.py
index 5f1bba3..0d98a14 100644
--- a/Lib/test/test_multiprocessing.py
+++ b/Lib/test/test_multiprocessing.py
@@ -1178,6 +1178,18 @@ class _TestPool(BaseTestCase):
join()
self.assertLess(join.elapsed, 0.5)
+ def test_empty_iterable(self):
+ # See Issue 12157
+ p = self.Pool(1)
+
+ self.assertEqual(p.map(sqr, []), [])
+ self.assertEqual(list(p.imap(sqr, [])), [])
+ self.assertEqual(list(p.imap_unordered(sqr, [])), [])
+ self.assertEqual(p.map_async(sqr, []).get(), [])
+
+ p.close()
+ p.join()
+
def raising():
raise KeyError("key")
@@ -2176,7 +2188,7 @@ class ProcessesMixin(object):
'Queue', 'Lock', 'RLock', 'Semaphore', 'BoundedSemaphore',
'Condition', 'Event', 'Value', 'Array', 'RawValue',
'RawArray', 'current_process', 'active_children', 'Pipe',
- 'connection', 'JoinableQueue'
+ 'connection', 'JoinableQueue', 'Pool'
)))
testcases_processes = create_test_cases(ProcessesMixin, type='processes')
@@ -2190,7 +2202,7 @@ class ManagerMixin(object):
locals().update(get_attributes(manager, (
'Queue', 'Lock', 'RLock', 'Semaphore', 'BoundedSemaphore',
'Condition', 'Event', 'Value', 'Array', 'list', 'dict',
- 'Namespace', 'JoinableQueue'
+ 'Namespace', 'JoinableQueue', 'Pool'
)))
testcases_manager = create_test_cases(ManagerMixin, type='manager')
@@ -2204,7 +2216,7 @@ class ThreadsMixin(object):
'Queue', 'Lock', 'RLock', 'Semaphore', 'BoundedSemaphore',
'Condition', 'Event', 'Value', 'Array', 'current_process',
'active_children', 'Pipe', 'connection', 'dict', 'list',
- 'Namespace', 'JoinableQueue'
+ 'Namespace', 'JoinableQueue', 'Pool'
)))
testcases_threads = create_test_cases(ThreadsMixin, type='threads')