diff options
author | Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> | 2022-10-08 00:29:09 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-10-08 00:29:09 (GMT) |
commit | 8ba9378b168ad330c158a001afca03d6c028d39b (patch) | |
tree | 3bd0eee04709afec69d16402c9eeb08a43f49f59 /Lib | |
parent | 3d8b22454728b6d54cc476cfb59e47ab40f3f527 (diff) | |
download | cpython-8ba9378b168ad330c158a001afca03d6c028d39b.zip cpython-8ba9378b168ad330c158a001afca03d6c028d39b.tar.gz cpython-8ba9378b168ad330c158a001afca03d6c028d39b.tar.bz2 |
GH-98023: Change default child watcher to PidfdChildWatcher on supported systems (#98024)
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/asyncio/unix_events.py | 16 | ||||
-rw-r--r-- | Lib/test/test_asyncio/test_unix_events.py | 14 |
2 files changed, 28 insertions, 2 deletions
diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py index 0f67b4d..7fc75cd 100644 --- a/Lib/asyncio/unix_events.py +++ b/Lib/asyncio/unix_events.py @@ -1403,6 +1403,17 @@ class ThreadedChildWatcher(AbstractChildWatcher): self._threads.pop(expected_pid) +def can_use_pidfd(): + if not hasattr(os, 'pidfd_open'): + return False + try: + pid = os.getpid() + os.close(os.pidfd_open(pid, 0)) + except OSError: + # blocked by security policy like SECCOMP + return False + return True + class _UnixDefaultEventLoopPolicy(events.BaseDefaultEventLoopPolicy): """UNIX event loop policy with a watcher for child processes.""" @@ -1415,7 +1426,10 @@ class _UnixDefaultEventLoopPolicy(events.BaseDefaultEventLoopPolicy): def _init_watcher(self): with events._lock: if self._watcher is None: # pragma: no branch - self._watcher = ThreadedChildWatcher() + if can_use_pidfd(): + self._watcher = PidfdChildWatcher() + else: + self._watcher = ThreadedChildWatcher() if threading.current_thread() is threading.main_thread(): self._watcher.attach_loop(self._local._loop) diff --git a/Lib/test/test_asyncio/test_unix_events.py b/Lib/test/test_asyncio/test_unix_events.py index 5bad21e..03fb5e6 100644 --- a/Lib/test/test_asyncio/test_unix_events.py +++ b/Lib/test/test_asyncio/test_unix_events.py @@ -1702,7 +1702,8 @@ class PolicyTests(unittest.TestCase): def test_get_default_child_watcher(self): policy = self.create_policy() self.assertIsNone(policy._watcher) - + unix_events.can_use_pidfd = mock.Mock() + unix_events.can_use_pidfd.return_value = False watcher = policy.get_child_watcher() self.assertIsInstance(watcher, asyncio.ThreadedChildWatcher) @@ -1710,6 +1711,17 @@ class PolicyTests(unittest.TestCase): self.assertIs(watcher, policy.get_child_watcher()) + policy = self.create_policy() + self.assertIsNone(policy._watcher) + unix_events.can_use_pidfd = mock.Mock() + unix_events.can_use_pidfd.return_value = True + watcher = policy.get_child_watcher() + self.assertIsInstance(watcher, asyncio.PidfdChildWatcher) + + self.assertIs(policy._watcher, watcher) + + self.assertIs(watcher, policy.get_child_watcher()) + def test_get_child_watcher_after_set(self): policy = self.create_policy() watcher = asyncio.FastChildWatcher() |