diff options
author | Victor Stinner <victor.stinner@haypocalc.com> | 2011-05-25 20:47:16 (GMT) |
---|---|---|
committer | Victor Stinner <victor.stinner@haypocalc.com> | 2011-05-25 20:47:16 (GMT) |
commit | a80987f20d0c73532127e1c3f69f7983c5c443d2 (patch) | |
tree | 7747598f8d947aada125c326de1940792ae69d39 /Lib | |
parent | b79f28ccbd0cde0580a8d7198ac62e97e7cfb4c4 (diff) | |
download | cpython-a80987f20d0c73532127e1c3f69f7983c5c443d2.zip cpython-a80987f20d0c73532127e1c3f69f7983c5c443d2.tar.gz cpython-a80987f20d0c73532127e1c3f69f7983c5c443d2.tar.bz2 |
Issue #12175: RawIOBase.readall() now returns None if read() returns None.
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/_pyio.py | 6 | ||||
-rw-r--r-- | Lib/test/test_io.py | 7 |
2 files changed, 10 insertions, 3 deletions
diff --git a/Lib/_pyio.py b/Lib/_pyio.py index fa00eb4..5474a4e 100644 --- a/Lib/_pyio.py +++ b/Lib/_pyio.py @@ -556,7 +556,11 @@ class RawIOBase(IOBase): if not data: break res += data - return bytes(res) + if res: + return bytes(res) + else: + # b'' or None + return data def readinto(self, b): """Read up to len(b) bytes into b. diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py index 109c82d..5333bb6 100644 --- a/Lib/test/test_io.py +++ b/Lib/test/test_io.py @@ -790,14 +790,17 @@ class BufferedReaderTest(unittest.TestCase, CommonBufferedTests): # Inject some None's in there to simulate EWOULDBLOCK rawio = self.MockRawIO((b"abc", b"d", None, b"efg", None, None, None)) bufio = self.tp(rawio) - self.assertEqual(b"abcd", bufio.read(6)) self.assertEqual(b"e", bufio.read(1)) self.assertEqual(b"fg", bufio.read()) self.assertEqual(b"", bufio.peek(1)) - self.assertTrue(None is bufio.read()) + self.assertIsNone(bufio.read()) self.assertEqual(b"", bufio.read()) + rawio = self.MockRawIO((b"a", None, None)) + self.assertEqual(b"a", rawio.readall()) + self.assertIsNone(rawio.readall()) + def test_read_past_eof(self): rawio = self.MockRawIO((b"abc", b"d", b"efg")) bufio = self.tp(rawio) |