diff options
| author | Gregory P. Smith <greg@krypto.org> | 2013-12-08 03:12:46 (GMT) |
|---|---|---|
| committer | Gregory P. Smith <greg@krypto.org> | 2013-12-08 03:12:46 (GMT) |
| commit | 774f909489ca1395ba1e3f3a1f3d43495df6cdfe (patch) | |
| tree | 19aa4184aac613938b75afcc89b2514fb0ba2949 /Lib | |
| parent | 6c527cf37f9ca6249f523ef3a59e27e64cc13e87 (diff) | |
| download | cpython-774f909489ca1395ba1e3f3a1f3d43495df6cdfe.zip cpython-774f909489ca1395ba1e3f3a1f3d43495df6cdfe.tar.gz cpython-774f909489ca1395ba1e3f3a1f3d43495df6cdfe.tar.bz2 | |
Fixes issue #19506: Use a memoryview to avoid a data copy when piping data
to stdin within subprocess.Popen.communicate. 5-10% less cpu usage.
Diffstat (limited to 'Lib')
| -rw-r--r-- | Lib/subprocess.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/Lib/subprocess.py b/Lib/subprocess.py index c3a2788..546a7a0 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -1621,6 +1621,9 @@ class Popen(object): self._save_input(input) + if self._input: + input_view = memoryview(self._input) + while self._fd2file: timeout = self._remaining_time(endtime) if timeout is not None and timeout < 0: @@ -1638,8 +1641,8 @@ class Popen(object): for fd, mode in ready: if mode & select.POLLOUT: - chunk = self._input[self._input_offset : - self._input_offset + _PIPE_BUF] + chunk = input_view[self._input_offset : + self._input_offset + _PIPE_BUF] try: self._input_offset += os.write(fd, chunk) except OSError as e: |