diff options
author | Ronald Oussoren <ronaldoussoren@mac.com> | 2011-05-06 08:23:04 (GMT) |
---|---|---|
committer | Ronald Oussoren <ronaldoussoren@mac.com> | 2011-05-06 08:23:04 (GMT) |
commit | f51738b10e83d0adf404ca989970a5b44700d685 (patch) | |
tree | 1fc30e8a697333459b9e0a8eb4ff14bd92084a96 /Lib | |
parent | d92ab0806d38cc592f303545d649821daa802997 (diff) | |
download | cpython-f51738b10e83d0adf404ca989970a5b44700d685.zip cpython-f51738b10e83d0adf404ca989970a5b44700d685.tar.gz cpython-f51738b10e83d0adf404ca989970a5b44700d685.tar.bz2 |
Fix for issue 10684: Folders get deleted when trying to change case with shutil.move (case insensitive file systems only)
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/shutil.py | 8 | ||||
-rw-r--r-- | Lib/test/test_shutil.py | 18 |
2 files changed, 25 insertions, 1 deletions
diff --git a/Lib/shutil.py b/Lib/shutil.py index 4862ae6..781840d 100644 --- a/Lib/shutil.py +++ b/Lib/shutil.py @@ -260,12 +260,18 @@ def move(src, dst): """ real_dst = dst if os.path.isdir(dst): + if _samefile(src, dst): + # We might be on a case insensitive filesystem, + # perform the rename anyway. + os.rename(src, dst) + return + real_dst = os.path.join(dst, _basename(src)) if os.path.exists(real_dst): raise Error("Destination path '%s' already exists" % real_dst) try: os.rename(src, real_dst) - except OSError: + except OSError as exc: if os.path.isdir(src): if _destinsrc(src, dst): raise Error("Cannot move a directory '%s' into itself '%s'." % (src, dst)) diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py index becd91c..8547351 100644 --- a/Lib/test/test_shutil.py +++ b/Lib/test/test_shutil.py @@ -522,6 +522,24 @@ class TestCopyFile(unittest.TestCase): self.assertTrue(srcfile._exited_with[0] is None) self.assertTrue(srcfile._raised) + def test_move_dir_caseinsensitive(self): + # Renames a folder to the same name + # but a different case. + + self.src_dir = tempfile.mkdtemp() + dst_dir = os.path.join( + os.path.dirname(self.src_dir), + os.path.basename(self.src_dir).upper()) + self.assertNotEqual(self.src_dir, dst_dir) + + try: + shutil.move(self.src_dir, dst_dir) + self.assertTrue(os.path.isdir(dst_dir)) + finally: + if os.path.exists(dst_dir): + os.rmdir(dst_dir) + + def test_main(): support.run_unittest(TestShutil, TestMove, TestCopyFile) |