summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorPaul Ganssle <pganssle@users.noreply.github.com>2017-11-09 21:34:29 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2017-11-09 21:34:29 (GMT)
commit191e993365ac3206f46132dcf46236471ec54bfa (patch)
tree56093f01ed019b5b0d6e3c6b5bc4600721b8438f /Lib
parent72fa3014d5afa5e9ee407dee132991185da33c10 (diff)
downloadcpython-191e993365ac3206f46132dcf46236471ec54bfa.zip
cpython-191e993365ac3206f46132dcf46236471ec54bfa.tar.gz
cpython-191e993365ac3206f46132dcf46236471ec54bfa.tar.bz2
bpo-31222: Make (datetime|date|time).replace return subclass type in Pure Python (#4176)
Diffstat (limited to 'Lib')
-rw-r--r--Lib/datetime.py6
-rw-r--r--Lib/test/datetimetester.py14
2 files changed, 17 insertions, 3 deletions
diff --git a/Lib/datetime.py b/Lib/datetime.py
index 2f03847..67d8600 100644
--- a/Lib/datetime.py
+++ b/Lib/datetime.py
@@ -828,7 +828,7 @@ class date:
month = self._month
if day is None:
day = self._day
- return date(year, month, day)
+ return type(self)(year, month, day)
# Comparisons of date objects with other.
@@ -1316,7 +1316,7 @@ class time:
tzinfo = self.tzinfo
if fold is None:
fold = self._fold
- return time(hour, minute, second, microsecond, tzinfo, fold=fold)
+ return type(self)(hour, minute, second, microsecond, tzinfo, fold=fold)
# Pickle support.
@@ -1597,7 +1597,7 @@ class datetime(date):
tzinfo = self.tzinfo
if fold is None:
fold = self.fold
- return datetime(year, month, day, hour, minute, second,
+ return type(self)(year, month, day, hour, minute, second,
microsecond, tzinfo, fold=fold)
def _local_timezone(self):
diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
index c5f91fb..5b58e99 100644
--- a/Lib/test/datetimetester.py
+++ b/Lib/test/datetimetester.py
@@ -1520,6 +1520,13 @@ class TestDate(HarmlessMixedComparison, unittest.TestCase):
base = cls(2000, 2, 29)
self.assertRaises(ValueError, base.replace, year=2001)
+ def test_subclass_replace(self):
+ class DateSubclass(self.theclass):
+ pass
+
+ dt = DateSubclass(2012, 1, 1)
+ self.assertIs(type(dt.replace(year=2013)), DateSubclass)
+
def test_subclass_date(self):
class C(self.theclass):
@@ -2626,6 +2633,13 @@ class TestTime(HarmlessMixedComparison, unittest.TestCase):
self.assertRaises(ValueError, base.replace, second=100)
self.assertRaises(ValueError, base.replace, microsecond=1000000)
+ def test_subclass_replace(self):
+ class TimeSubclass(self.theclass):
+ pass
+
+ ctime = TimeSubclass(12, 30)
+ self.assertIs(type(ctime.replace(hour=10)), TimeSubclass)
+
def test_subclass_time(self):
class C(self.theclass):