summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorDaniel Hahler <github@thequod.de>2019-03-12 03:29:04 (GMT)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-03-12 03:29:04 (GMT)
commit3e936431e23b424b1e4665e8165c245924f0ab02 (patch)
treee06867ae81a11929c45b8dd40dde1cded3eb7fc7 /Lib
parent1ceb3a3d172dcf0ddff38d5d6b559443ad065b84 (diff)
downloadcpython-3e936431e23b424b1e4665e8165c245924f0ab02.zip
cpython-3e936431e23b424b1e4665e8165c245924f0ab02.tar.gz
cpython-3e936431e23b424b1e4665e8165c245924f0ab02.tar.bz2
bpo-35931: Gracefully handle any exception in pdb debug command (GH-12103)
This is relevant for `debug doesnotexist()`, which would crash with a NameError otherwise.
Diffstat (limited to 'Lib')
-rwxr-xr-xLib/pdb.py12
-rw-r--r--Lib/test/test_pdb.py22
2 files changed, 23 insertions, 11 deletions
diff --git a/Lib/pdb.py b/Lib/pdb.py
index 1443f9f..bf3219a 100755
--- a/Lib/pdb.py
+++ b/Lib/pdb.py
@@ -1093,16 +1093,14 @@ class Pdb(bdb.Bdb, cmd.Cmd):
sys.settrace(None)
globals = self.curframe.f_globals
locals = self.curframe_locals
- try:
- code = compile(arg, "<string>", "exec")
- except SyntaxError:
- exc_info = sys.exc_info()[:2]
- self.error(traceback.format_exception_only(*exc_info)[-1].strip())
- return
p = Pdb(self.completekey, self.stdin, self.stdout)
p.prompt = "(%s) " % self.prompt.strip()
self.message("ENTERING RECURSIVE DEBUGGER")
- sys.call_tracing(p.run, (code, globals, locals))
+ try:
+ sys.call_tracing(p.run, (arg, globals, locals))
+ except Exception:
+ exc_info = sys.exc_info()[:2]
+ self.error(traceback.format_exception_only(*exc_info)[-1].strip())
self.message("LEAVING RECURSIVE DEBUGGER")
sys.settrace(self.trace_dispatch)
self.lastcmd = p.lastcmd
diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py
index 21f6b70..7e03df0 100644
--- a/Lib/test/test_pdb.py
+++ b/Lib/test/test_pdb.py
@@ -1486,12 +1486,26 @@ class PdbTestCase(unittest.TestCase):
stdout, _ = self._run_pdb(['-m', self.module_name + '.runme'], commands)
self.assertTrue(any("VAR from module" in l for l in stdout.splitlines()), stdout)
- def test_syntaxerror_in_command(self):
- commands = "print(\ndebug print("
- stdout, _ = self.run_pdb_script("", commands)
+ def test_errors_in_command(self):
+ commands = "\n".join([
+ 'print(',
+ 'debug print(',
+ 'debug doesnotexist',
+ 'c',
+ ])
+ stdout, _ = self.run_pdb_script('', commands + '\n')
+
self.assertEqual(stdout.splitlines()[1:], [
'(Pdb) *** SyntaxError: unexpected EOF while parsing',
- '(Pdb) *** SyntaxError: unexpected EOF while parsing',
+
+ '(Pdb) ENTERING RECURSIVE DEBUGGER',
+ '*** SyntaxError: unexpected EOF while parsing',
+ 'LEAVING RECURSIVE DEBUGGER',
+
+ '(Pdb) ENTERING RECURSIVE DEBUGGER',
+ '> <string>(1)<module>()',
+ "((Pdb)) *** NameError: name 'doesnotexist' is not defined",
+ 'LEAVING RECURSIVE DEBUGGER',
'(Pdb) ',
])