summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorOleg Iarygin <oleg@arhadthedev.net>2023-03-27 23:21:07 (GMT)
committerGitHub <noreply@github.com>2023-03-27 23:21:07 (GMT)
commit56d055a0d81a809e4ff8e1d56756a3bf32317efb (patch)
treea7b12f88c2a8496a23b3ab41d60836bf8e8b1c66 /Lib
parent89e67ada6958cfd8d4eec221848f81b2619de099 (diff)
downloadcpython-56d055a0d81a809e4ff8e1d56756a3bf32317efb.zip
cpython-56d055a0d81a809e4ff8e1d56756a3bf32317efb.tar.gz
cpython-56d055a0d81a809e4ff8e1d56756a3bf32317efb.tar.bz2
gh-74468: [tarfile] Fix incorrect name attribute of ExFileObject (GH-102424)
Co-authored-by: Simeon Visser <svisser@users.noreply.github.com>
Diffstat (limited to 'Lib')
-rwxr-xr-xLib/tarfile.py6
-rw-r--r--Lib/test/test_tarfile.py7
2 files changed, 10 insertions, 3 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index d686435..b733195 100755
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -601,12 +601,12 @@ class _FileInFile(object):
object.
"""
- def __init__(self, fileobj, offset, size, blockinfo=None):
+ def __init__(self, fileobj, offset, size, name, blockinfo=None):
self.fileobj = fileobj
self.offset = offset
self.size = size
self.position = 0
- self.name = getattr(fileobj, "name", None)
+ self.name = name
self.closed = False
if blockinfo is None:
@@ -703,7 +703,7 @@ class ExFileObject(io.BufferedReader):
def __init__(self, tarfile, tarinfo):
fileobj = _FileInFile(tarfile.fileobj, tarinfo.offset_data,
- tarinfo.size, tarinfo.sparse)
+ tarinfo.size, tarinfo.name, tarinfo.sparse)
super().__init__(fileobj)
#class ExFileObject
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 75b60e9..39f6f49 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -479,6 +479,13 @@ class CommonReadTest(ReadTest):
with tarfile.open(support.findfile('recursion.tar')) as tar:
pass
+ def test_extractfile_name(self):
+ # gh-74468: TarFile.name must name a file, not a parent archive.
+ file = self.tar.getmember('ustar/regtype')
+ with self.tar.extractfile(file) as fobj:
+ self.assertEqual(fobj.name, 'ustar/regtype')
+
+
class MiscReadTestBase(CommonReadTest):
def requires_name_attribute(self):
pass