summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorYury Selivanov <yury@magic.io>2018-05-29 19:38:07 (GMT)
committerGitHub <noreply@github.com>2018-05-29 19:38:07 (GMT)
commit5d97b7bcc19496617bf8c448d2f149cc28c73bc7 (patch)
tree3a8393d343de0c3a54040eaf380cc8b19eb1577d /Lib
parente55de2d77f10d524be0b426e587fbc820f76de71 (diff)
downloadcpython-5d97b7bcc19496617bf8c448d2f149cc28c73bc7.zip
cpython-5d97b7bcc19496617bf8c448d2f149cc28c73bc7.tar.gz
cpython-5d97b7bcc19496617bf8c448d2f149cc28c73bc7.tar.bz2
bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208)
Original patch by Dan O'Reilly.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/asyncio/events.py7
-rw-r--r--Lib/test/test_asyncio/test_unix_events.py32
2 files changed, 39 insertions, 0 deletions
diff --git a/Lib/asyncio/events.py b/Lib/asyncio/events.py
index 40946bb..68dc25e 100644
--- a/Lib/asyncio/events.py
+++ b/Lib/asyncio/events.py
@@ -625,16 +625,23 @@ class BaseDefaultEventLoopPolicy(AbstractEventLoopPolicy):
class _Local(threading.local):
_loop = None
+ _pid = None
_set_called = False
def __init__(self):
self._local = self._Local()
+ self._local._pid = os.getpid()
def get_event_loop(self):
"""Get the event loop.
This may be None or an instance of EventLoop.
"""
+ if self._local._pid != os.getpid():
+ # If we detect we're in a child process forked by multiprocessing,
+ # we reset self._local so that we'll get a new event loop.
+ self._local = self._Local()
+
if (self._local._loop is None and
not self._local._set_called and
isinstance(threading.current_thread(), threading._MainThread)):
diff --git a/Lib/test/test_asyncio/test_unix_events.py b/Lib/test/test_asyncio/test_unix_events.py
index a01efed..1bc2d86 100644
--- a/Lib/test/test_asyncio/test_unix_events.py
+++ b/Lib/test/test_asyncio/test_unix_events.py
@@ -13,6 +13,7 @@ import sys
import tempfile
import threading
import unittest
+import multiprocessing
from unittest import mock
from test import support
@@ -1804,6 +1805,37 @@ class FastChildWatcherTests (ChildWatcherTestsMixin, test_utils.TestCase):
return asyncio.FastChildWatcher()
+class ForkedProcessTests(unittest.TestCase):
+ def setUp(self):
+ self.parent_loop = asyncio.SelectorEventLoop()
+ asyncio.set_event_loop(self.parent_loop)
+ self.ctx = multiprocessing.get_context("fork")
+
+ def tearDown(self):
+ self.parent_loop.close()
+
+ def _check_loops_not_equal(self, old_loop):
+ loop = asyncio.get_event_loop()
+ if loop is old_loop:
+ raise RuntimeError("Child process inherited parent's event loop")
+
+ try:
+ val = loop.run_until_complete(asyncio.sleep(0.05, result=42))
+ if val != 42:
+ raise RuntimeError("new event loop does not work")
+ finally:
+ loop.close()
+
+ sys.exit(loop is old_loop)
+
+ def test_new_loop_in_child(self):
+ p = self.ctx.Process(target=self._check_loops_not_equal,
+ args=(self.parent_loop,))
+ p.start()
+ p.join()
+ self.assertEqual(p.exitcode, 0)
+
+
class PolicyTests(unittest.TestCase):
def create_policy(self):