summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2024-06-15 11:54:07 (GMT)
committerGitHub <noreply@github.com>2024-06-15 11:54:07 (GMT)
commit767c955544fa79486e3e874ed9d74e8991b1060b (patch)
tree71f3dd32c357aea2af70db0465331a320277e4d3 /Lib
parente54a28bcc9114f296bd1d63010eedbd0c2140d71 (diff)
downloadcpython-767c955544fa79486e3e874ed9d74e8991b1060b.zip
cpython-767c955544fa79486e3e874ed9d74e8991b1060b.tar.gz
cpython-767c955544fa79486e3e874ed9d74e8991b1060b.tar.bz2
[3.13] gh-120544: Add `else: fail()` to tests where exception is expected (GH-120545) (#120546)
gh-120544: Add `else: fail()` to tests where exception is expected (GH-120545) (cherry picked from commit 42ebdd83bb194f054fe5a10b3caa0c3a95be3679) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Diffstat (limited to 'Lib')
-rw-r--r--Lib/test/test_exceptions.py2
-rw-r--r--Lib/test/test_unittest/test_case.py10
2 files changed, 12 insertions, 0 deletions
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index 3138f50..7e8e058 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1836,6 +1836,8 @@ class NameErrorTests(unittest.TestCase):
except self.failureException:
with support.captured_stderr() as err:
sys.__excepthook__(*sys.exc_info())
+ else:
+ self.fail("assertRaisesRegex should have failed.")
self.assertIn("aab", err.getvalue())
diff --git a/Lib/test/test_unittest/test_case.py b/Lib/test/test_unittest/test_case.py
index ed5eb56..82a442a 100644
--- a/Lib/test/test_unittest/test_case.py
+++ b/Lib/test/test_unittest/test_case.py
@@ -1132,6 +1132,8 @@ test case
# need to remove the first line of the error message
error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error)
+ else:
+ self.fail(f'{self.failureException} not raised')
def testAssertEqualSingleLine(self):
sample_text = "laden swallows fly slowly"
@@ -1148,6 +1150,8 @@ test case
# need to remove the first line of the error message
error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error)
+ else:
+ self.fail(f'{self.failureException} not raised')
def testAssertEqualwithEmptyString(self):
'''Verify when there is an empty string involved, the diff output
@@ -1165,6 +1169,8 @@ test case
# need to remove the first line of the error message
error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error)
+ else:
+ self.fail(f'{self.failureException} not raised')
def testAssertEqualMultipleLinesMissingNewlineTerminator(self):
'''Verifying format of diff output from assertEqual involving strings
@@ -1185,6 +1191,8 @@ test case
# need to remove the first line of the error message
error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error)
+ else:
+ self.fail(f'{self.failureException} not raised')
def testAssertEqualMultipleLinesMismatchedNewlinesTerminators(self):
'''Verifying format of diff output from assertEqual involving strings
@@ -1208,6 +1216,8 @@ test case
# need to remove the first line of the error message
error = str(e).split('\n', 1)[1]
self.assertEqual(sample_text_error, error)
+ else:
+ self.fail(f'{self.failureException} not raised')
def testEqualityBytesWarning(self):
if sys.flags.bytes_warning: