summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorVinay Sajip <vinay_sajip@yahoo.co.uk>2017-01-15 10:06:52 (GMT)
committerVinay Sajip <vinay_sajip@yahoo.co.uk>2017-01-15 10:06:52 (GMT)
commit61eda7260ac9fcdb6c5f066eb48dc344544bdfa6 (patch)
tree9beae3f1525cc5b9e43774bcdc62dd23950988fb /Lib
parent2e1b6ea4b7b2ca2c9deab8bc7737b1337bdb192a (diff)
downloadcpython-61eda7260ac9fcdb6c5f066eb48dc344544bdfa6.zip
cpython-61eda7260ac9fcdb6c5f066eb48dc344544bdfa6.tar.gz
cpython-61eda7260ac9fcdb6c5f066eb48dc344544bdfa6.tar.bz2
Fixed #29132: Updated shlex to work better with punctuation chars in POSIX mode.
Thanks to Evan_ for the report and patch.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/shlex.py10
-rw-r--r--Lib/test/test_shlex.py8
2 files changed, 13 insertions, 5 deletions
diff --git a/Lib/shlex.py b/Lib/shlex.py
index e87266f..2c9786c 100644
--- a/Lib/shlex.py
+++ b/Lib/shlex.py
@@ -232,11 +232,6 @@ class shlex:
break # emit current token
else:
continue
- elif self.posix and nextchar in self.quotes:
- self.state = nextchar
- elif self.posix and nextchar in self.escape:
- escapedstate = 'a'
- self.state = nextchar
elif self.state == 'c':
if nextchar in self.punctuation_chars:
self.token += nextchar
@@ -245,6 +240,11 @@ class shlex:
self._pushback_chars.append(nextchar)
self.state = ' '
break
+ elif self.posix and nextchar in self.quotes:
+ self.state = nextchar
+ elif self.posix and nextchar in self.escape:
+ escapedstate = 'a'
+ self.state = nextchar
elif (nextchar in self.wordchars or nextchar in self.quotes
or self.whitespace_split):
self.token += nextchar
diff --git a/Lib/test/test_shlex.py b/Lib/test/test_shlex.py
index 3936c97..fd35788 100644
--- a/Lib/test/test_shlex.py
+++ b/Lib/test/test_shlex.py
@@ -273,6 +273,14 @@ class ShlexTest(unittest.TestCase):
# white space
self.assertEqual(list(s), ['a', '&&', 'b', '||', 'c'])
+ def testPunctuationWithPosix(self):
+ """Test that punctuation_chars and posix behave correctly together."""
+ # see Issue #29132
+ s = shlex.shlex('f >"abc"', posix=True, punctuation_chars=True)
+ self.assertEqual(list(s), ['f', '>', 'abc'])
+ s = shlex.shlex('f >\\"abc\\"', posix=True, punctuation_chars=True)
+ self.assertEqual(list(s), ['f', '>', '"abc"'])
+
def testEmptyStringHandling(self):
"""Test that parsing of empty strings is correctly handled."""
# see Issue #21999