summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSenthil Kumaran <senthil@uthcode.com>2011-10-05 16:32:52 (GMT)
committerSenthil Kumaran <senthil@uthcode.com>2011-10-05 16:32:52 (GMT)
commit55a190fbbddea150498a06351c66170c0a4a51bf (patch)
treec9c28f9440f3da6361193769a078801042e89622 /Lib
parent91a076a72f22e0c7ad997d46be76f7021a27ba6a (diff)
parent1b7da519b09d8885272d323af982d36675419075 (diff)
downloadcpython-55a190fbbddea150498a06351c66170c0a4a51bf.zip
cpython-55a190fbbddea150498a06351c66170c0a4a51bf.tar.gz
cpython-55a190fbbddea150498a06351c66170c0a4a51bf.tar.bz2
merge from 3.2. Issue13104 - Fix urllib.request.thishost() utility function.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/test/test_urllib.py4
-rw-r--r--Lib/urllib/request.py2
2 files changed, 5 insertions, 1 deletions
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index 671708a..77637a6 100644
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -1058,6 +1058,10 @@ class Utility_Tests(unittest.TestCase):
self.assertEqual(('user', 'a\vb'),urllib.parse.splitpasswd('user:a\vb'))
self.assertEqual(('user', 'a:b'),urllib.parse.splitpasswd('user:a:b'))
+ def test_thishost(self):
+ """Test the urllib.request.thishost utility function returns a tuple"""
+ self.assertIsInstance(urllib.request.thishost(), tuple)
+
class URLopener_Tests(unittest.TestCase):
"""Testcase to test the open method of URLopener class."""
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index 4a571e8..671ab68 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -2125,7 +2125,7 @@ def thishost():
"""Return the IP addresses of the current host."""
global _thishost
if _thishost is None:
- _thishost = tuple(socket.gethostbyname_ex(socket.gethostname()[2]))
+ _thishost = tuple(socket.gethostbyname_ex(socket.gethostname())[2])
return _thishost
_ftperrors = None