summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorÉric Araujo <aeric@mtlpy.org>2012-12-08 19:51:47 (GMT)
committerÉric Araujo <aeric@mtlpy.org>2012-12-08 19:51:47 (GMT)
commitd61926e6bef6c4d8105a2848362377dce91d7fc8 (patch)
tree086c3eb21955cb14a46cd0f8a14bb8bbaa0b5fd7 /Lib
parent3e4a3dcb23d849fa0ce5f5009e83606abaef15aa (diff)
downloadcpython-d61926e6bef6c4d8105a2848362377dce91d7fc8.zip
cpython-d61926e6bef6c4d8105a2848362377dce91d7fc8.tar.gz
cpython-d61926e6bef6c4d8105a2848362377dce91d7fc8.tar.bz2
Create ~/.pypirc securely (#13512).
There was a window between the write and the chmod where the user’s password would be exposed, depending on default permissions. Philip Jenvey’s patch fixes it.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/distutils/config.py11
1 files changed, 1 insertions, 10 deletions
diff --git a/Lib/distutils/config.py b/Lib/distutils/config.py
index 5b625f3..1fd5334 100644
--- a/Lib/distutils/config.py
+++ b/Lib/distutils/config.py
@@ -4,7 +4,6 @@ Provides the PyPIRCCommand class, the base class for the command classes
that uses .pypirc in the distutils.command package.
"""
import os
-import sys
from configparser import ConfigParser
from distutils.cmd import Command
@@ -43,16 +42,8 @@ class PyPIRCCommand(Command):
def _store_pypirc(self, username, password):
"""Creates a default .pypirc file."""
rc = self._get_rc_file()
- f = open(rc, 'w')
- try:
+ with os.fdopen(os.open(rc, os.O_CREAT | os.O_WRONLY, 0o600), 'w') as f:
f.write(DEFAULT_PYPIRC % (username, password))
- finally:
- f.close()
- try:
- os.chmod(rc, 0o600)
- except OSError:
- # should do something better here
- pass
def _read_pypirc(self):
"""Reads the .pypirc file."""