summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorGiampaolo Rodola <g.rodola@gmail.com>2019-04-09 02:42:06 (GMT)
committerGitHub <noreply@github.com>2019-04-09 02:42:06 (GMT)
commit8702b67dad62a9084f6c1823dce10653743667c8 (patch)
treee43d21d01315d3543754a3e43119e5158d6f5dbd /Lib
parent79b5d29041bd85ea3baa050b3fa2481344ea35c9 (diff)
downloadcpython-8702b67dad62a9084f6c1823dce10653743667c8.zip
cpython-8702b67dad62a9084f6c1823dce10653743667c8.tar.gz
cpython-8702b67dad62a9084f6c1823dce10653743667c8.tar.bz2
BPO-17561: set create_server backlog default to None (GH-12735)
It turns out doing socket.listen(0) does not equal to "choose a reasonable default". It actually means "set backlog to 0". As such set backlog=None as the default for socket.create_server. Fixes the following BB failures: https://github.com/python/cpython/pull/11784#issuecomment-481036369 Ref. BPO-1756, GH-11784.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/socket.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/Lib/socket.py b/Lib/socket.py
index 2e51cd1..0dd8ec7 100644
--- a/Lib/socket.py
+++ b/Lib/socket.py
@@ -745,7 +745,7 @@ def has_dualstack_ipv6():
return False
-def create_server(address, *, family=AF_INET, backlog=0, reuse_port=False,
+def create_server(address, *, family=AF_INET, backlog=None, reuse_port=False,
dualstack_ipv6=False):
"""Convenience function which creates a SOCK_STREAM type socket
bound to *address* (a 2-tuple (host, port)) and return the socket
@@ -804,7 +804,10 @@ def create_server(address, *, family=AF_INET, backlog=0, reuse_port=False,
msg = '%s (while attempting to bind on address %r)' % \
(err.strerror, address)
raise error(err.errno, msg) from None
- sock.listen(backlog)
+ if backlog is None:
+ sock.listen()
+ else:
+ sock.listen(backlog)
return sock
except error:
sock.close()