summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorVinay Sajip <vinay_sajip@yahoo.co.uk>2010-08-23 17:50:30 (GMT)
committerVinay Sajip <vinay_sajip@yahoo.co.uk>2010-08-23 17:50:30 (GMT)
commitde6e9d615ddada40fb0ee4e005777eb73a147058 (patch)
tree1e30d8b71d6e8633465ef9a7002add8dbf85453b /Lib
parent06b8b10090ccfb520d8dbe3b38a1b35b11ee4207 (diff)
downloadcpython-de6e9d615ddada40fb0ee4e005777eb73a147058.zip
cpython-de6e9d615ddada40fb0ee4e005777eb73a147058.tar.gz
cpython-de6e9d615ddada40fb0ee4e005777eb73a147058.tar.bz2
Issue #9501: Fixed logging regressions in cleanup code.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/logging/__init__.py28
1 files changed, 20 insertions, 8 deletions
diff --git a/Lib/logging/__init__.py b/Lib/logging/__init__.py
index dca0017..b4eaab6 100644
--- a/Lib/logging/__init__.py
+++ b/Lib/logging/__init__.py
@@ -609,12 +609,16 @@ def _removeHandlerRef(wr):
"""
Remove a handler reference from the internal cleanup list.
"""
- _acquireLock()
- try:
- if wr in _handlerList:
- _handlerList.remove(wr)
- finally:
- _releaseLock()
+ # This function can be called during module teardown, when globals are
+ # set to None. If _acquireLock is None, assume this is the case and do
+ # nothing.
+ if _acquireLock is not None:
+ _acquireLock()
+ try:
+ if wr in _handlerList:
+ _handlerList.remove(wr)
+ finally:
+ _releaseLock()
def _addHandlerRef(handler):
"""
@@ -1604,8 +1608,16 @@ def shutdown(handlerList=_handlerList):
#we just ignore them if raiseExceptions is not set
try:
h = wr()
- h.flush()
- h.close()
+ if h:
+ try:
+ h.flush()
+ h.close()
+ except (IOError, ValueError):
+ # Ignore errors which might be caused
+ # because handlers have been closed but
+ # references to them are still around at
+ # application exit.
+ pass
except:
if raiseExceptions:
raise