diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-06-21 07:54:04 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-06-21 07:54:04 (GMT) |
commit | 175e264d363164c905b08688bbda751c9ff26342 (patch) | |
tree | 4b3b7a01834b4793921a5d798f5c8aa63b545369 /Lib | |
parent | 533bff4e9fe221a7c9cf12795fd2d002e87bfa6a (diff) | |
download | cpython-175e264d363164c905b08688bbda751c9ff26342.zip cpython-175e264d363164c905b08688bbda751c9ff26342.tar.gz cpython-175e264d363164c905b08688bbda751c9ff26342.tar.bz2 |
bpo-44469: Fix tests for "async with" with bad object (GH-26817)
Test for execution of the body was null. It would pass
even if the code which should be skipped was executed.
(cherry picked from commit 5d2b3a0d688cf8a33db3d266c9e7049c13766a4c)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Diffstat (limited to 'Lib')
-rw-r--r-- | Lib/test/test_coroutines.py | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/Lib/test/test_coroutines.py b/Lib/test/test_coroutines.py index 8d1e069..1e01e3b 100644 --- a/Lib/test/test_coroutines.py +++ b/Lib/test/test_coroutines.py @@ -1203,41 +1203,47 @@ class CoroutineTest(unittest.TestCase): def __aenter__(self): pass - body_executed = False + body_executed = None async def foo(): + nonlocal body_executed + body_executed = False async with CM(): body_executed = True with self.assertRaisesRegex(AttributeError, '__aexit__'): run_async(foo()) - self.assertFalse(body_executed) + self.assertIs(body_executed, False) def test_with_3(self): class CM: def __aexit__(self): pass - body_executed = False + body_executed = None async def foo(): + nonlocal body_executed + body_executed = False async with CM(): body_executed = True with self.assertRaisesRegex(AttributeError, '__aenter__'): run_async(foo()) - self.assertFalse(body_executed) + self.assertIs(body_executed, False) def test_with_4(self): class CM: pass - body_executed = False + body_executed = None async def foo(): + nonlocal body_executed + body_executed = False async with CM(): body_executed = True with self.assertRaisesRegex(AttributeError, '__aenter__'): run_async(foo()) - self.assertFalse(body_executed) + self.assertIs(body_executed, False) def test_with_5(self): # While this test doesn't make a lot of sense, |