summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2013-05-09 11:22:26 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2013-05-09 11:22:26 (GMT)
commit263fab94ee1f32b53b709c25c76044719d0eb88e (patch)
treec4aa65d9c62a46d7726e47407dbb3eeba9040ab2 /Lib
parent6bcc0f1b5161adf0773ebeba77f1d7662aad4f0e (diff)
downloadcpython-263fab94ee1f32b53b709c25c76044719d0eb88e.zip
cpython-263fab94ee1f32b53b709c25c76044719d0eb88e.tar.gz
cpython-263fab94ee1f32b53b709c25c76044719d0eb88e.tar.bz2
Issue #16601: Restarting iteration over tarfile no more continues from where
it left off. Patch by Michael Birtwell.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/tarfile.py12
-rw-r--r--Lib/test/test_tarfile.py8
2 files changed, 15 insertions, 5 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index 11b4b68..6693840 100644
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -2398,16 +2398,18 @@ class TarIter:
# Fix for SF #1100429: Under rare circumstances it can
# happen that getmembers() is called during iteration,
# which will cause TarIter to stop prematurely.
- if not self.tarfile._loaded:
+
+ if self.index == 0 and self.tarfile.firstmember is not None:
+ tarinfo = self.tarfile.next()
+ elif self.index < len(self.tarfile.members):
+ tarinfo = self.tarfile.members[self.index]
+ elif not self.tarfile._loaded:
tarinfo = self.tarfile.next()
if not tarinfo:
self.tarfile._loaded = True
raise StopIteration
else:
- try:
- tarinfo = self.tarfile.members[self.index]
- except IndexError:
- raise StopIteration
+ raise StopIteration
self.index += 1
return tarinfo
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index b224bf0..9b98df2 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -415,6 +415,14 @@ class MiscReadTest(CommonReadTest):
finally:
support.unlink(empty)
+ def test_parallel_iteration(self):
+ # Issue #16601: Restarting iteration over tarfile continued
+ # from where it left off.
+ with tarfile.open(self.tarname) as tar:
+ for m1, m2 in zip(tar, tar):
+ self.assertEqual(m1.offset, m2.offset)
+ self.assertEqual(m1.get_info(), m2.get_info())
+
class StreamReadTest(CommonReadTest):