diff options
| author | Ronald Oussoren <ronaldoussoren@mac.com> | 2010-06-22 09:32:22 (GMT) |
|---|---|---|
| committer | Ronald Oussoren <ronaldoussoren@mac.com> | 2010-06-22 09:32:22 (GMT) |
| commit | 3ceab01cefa149ade3bed218e9c03ac791f0e8cc (patch) | |
| tree | 6c740a06eff132bd18a492bba3897ab6685e6e3b /Mac | |
| parent | 934f4e1f398bb0dd712f40ecf7957327bdae33f8 (diff) | |
| download | cpython-3ceab01cefa149ade3bed218e9c03ac791f0e8cc.zip cpython-3ceab01cefa149ade3bed218e9c03ac791f0e8cc.tar.gz cpython-3ceab01cefa149ade3bed218e9c03ac791f0e8cc.tar.bz2 | |
The code in _scproxy (a mac specific helper module to
detect proxy settings) had the wrong logic for detecting
if the checkbox 'Exclude simple hostnames' is checked. This
checkin fixes that.
As a result the test failure 'Issue8455' goes away on systems
where the checkbox is not checked.
I'm carefully avoiding saying that is fixes that issue,
test_urllib2_localnet assumes that system proxy settings are
empty (not just on OSX, see Issue8455 for details).
Diffstat (limited to 'Mac')
| -rw-r--r-- | Mac/Modules/_scproxy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Mac/Modules/_scproxy.c b/Mac/Modules/_scproxy.c index dd5a293..b393fd1 100644 --- a/Mac/Modules/_scproxy.c +++ b/Mac/Modules/_scproxy.c @@ -68,7 +68,7 @@ get_proxy_settings(PyObject* mod __attribute__((__unused__))) aNum = CFDictionaryGetValue(proxyDict, kSCPropNetProxiesExcludeSimpleHostnames); if (aNum == NULL) { - v = PyBool_FromLong(1); + v = PyBool_FromLong(0); } else { v = PyBool_FromLong(cfnum_to_int32(aNum)); } |