summaryrefslogtreecommitdiffstats
path: root/Makefile.pre.in
diff options
context:
space:
mode:
authorJeffery To <jeffery.to@gmail.com>2023-07-05 10:51:26 (GMT)
committerGitHub <noreply@github.com>2023-07-05 10:51:26 (GMT)
commit6c6a2a9143c301bd6101fb18fd7f3b96adafc43c (patch)
tree172a82060c840b69b981ddd2f99397fd1bd0e495 /Makefile.pre.in
parentedb29f0fbed652f1b03c107db8d055dfb8f179e1 (diff)
downloadcpython-6c6a2a9143c301bd6101fb18fd7f3b96adafc43c.zip
cpython-6c6a2a9143c301bd6101fb18fd7f3b96adafc43c.tar.gz
cpython-6c6a2a9143c301bd6101fb18fd7f3b96adafc43c.tar.bz2
[3.11] gh-104692: Include commoninstall as a prerequisite for bininstall (GH-104693) (#105429)
This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed. . (cherry picked from commit 990cb3676c2edb7e5787372d6cbe360a73367f4c) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Diffstat (limited to 'Makefile.pre.in')
-rw-r--r--Makefile.pre.in6
1 files changed, 5 insertions, 1 deletions
diff --git a/Makefile.pre.in b/Makefile.pre.in
index 3ea8653..3948184 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -1839,7 +1839,11 @@ altbininstall: $(BUILDPYTHON) @FRAMEWORKPYTHONW@
$(DESTDIR)$(BINDIR)/python$(VERSION)$(EXE); \
fi
-bininstall: altbininstall
+# We depend on commoninstall here to make sure the installation is already usable
+# before we possibly overwrite the global 'python3' symlink to avoid causing
+# problems for anything else trying to run 'python3' while we install, particularly
+# if we're installing in parallel with -j.
+bininstall: commoninstall altbininstall
if test ! -d $(DESTDIR)$(LIBPC); then \
echo "Creating directory $(LIBPC)"; \
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$(LIBPC); \