diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-04-22 17:03:36 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-22 17:03:36 (GMT) |
| commit | ef63328b46fe7402794cde51008a47e79f37b153 (patch) | |
| tree | a5d37d1f1edec82a88beaeaf3c5d80f46df9315a /Misc/NEWS.d/next/Library | |
| parent | f7bc44170b4bdd16c46b4b6acf7673ffc24dfb19 (diff) | |
| download | cpython-ef63328b46fe7402794cde51008a47e79f37b153.zip cpython-ef63328b46fe7402794cde51008a47e79f37b153.tar.gz cpython-ef63328b46fe7402794cde51008a47e79f37b153.tar.bz2 | |
bpo-43284: Update platform.win32_ver to use _syscmd_ver instead of sys.getwindowsversion() (GH-25500)
The sys module uses the kernel32.dll version number, which can vary from the "actual" Windows version.
Since the best option for getting the version is WMI (which is expensive), we switch back to launching cmd.exe (which is also expensive, but a lot less code on our part).
sys.getwindowsversion() is not updated to avoid launching executables from that module.
(cherry picked from commit 2a3f4899c63806439e5bcea0c30f7e6a6295a763)
Co-authored-by: Shreyan Avigyan <shreyan.avigyan@gmail.com>
Diffstat (limited to 'Misc/NEWS.d/next/Library')
| -rw-r--r-- | Misc/NEWS.d/next/Library/2021-04-21-14-50-57.bpo-43284.2QZn2T.rst | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Library/2021-04-21-14-50-57.bpo-43284.2QZn2T.rst b/Misc/NEWS.d/next/Library/2021-04-21-14-50-57.bpo-43284.2QZn2T.rst new file mode 100644 index 0000000..7e41016 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2021-04-21-14-50-57.bpo-43284.2QZn2T.rst @@ -0,0 +1,6 @@ +platform.win32_ver derives the windows version from +sys.getwindowsversion().platform_version which in turn derives the version +from kernel32.dll (which can be of a different version than Windows itself). +Therefore change the platform.win32_ver to determine the version using the +platform module's _syscmd_ver private function to return an accurate +version. |