diff options
| author | Brett Cannon <bcannon@gmail.com> | 2010-05-14 00:21:48 (GMT) |
|---|---|---|
| committer | Brett Cannon <bcannon@gmail.com> | 2010-05-14 00:21:48 (GMT) |
| commit | 42a0ba7b2c88b181bce603a57c69a66539dab693 (patch) | |
| tree | a2ae13d2ecee39e8fe5d4c5d478dabc5388aaf5e /Misc | |
| parent | da9af75d5f1be42097bc9929e48e9eee43555690 (diff) | |
| download | cpython-42a0ba7b2c88b181bce603a57c69a66539dab693.zip cpython-42a0ba7b2c88b181bce603a57c69a66539dab693.tar.gz cpython-42a0ba7b2c88b181bce603a57c69a66539dab693.tar.bz2 | |
subprocess.Popen.__del__ referenced global objects, which is a no-no thanks to
interpreter shutdown semantics. Same issue goes for the methods that __del__
called. Now all the methods capture the global objects it needs as default
values to private parameters (could have stuck them on the class object itself,
but since the objects have nothing directly to do with the class that seemed
wrong).
There is no test as making one that works is hard. This patch was
verified against a consistently failing test in Mercurial's test suite, though,
so it has been tested in some regard.
Closes issue #5099. Thanks to Mary Stern for the bug report and Gabriel
Genellina for writing another patch for the same issue and attempting to write
a test.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS | 4 |
1 files changed, 4 insertions, 0 deletions
@@ -15,6 +15,10 @@ Core and Builtins Library ------- +- Issue #5099: subprocess.Popen's __del__ method (and the methods it calls) + referenced global objects, causing errors to pop up during interpreter + shutdown. + Extension Modules ----------------- |