diff options
| author | Éric Araujo <merwok@netwok.org> | 2011-08-02 01:16:12 (GMT) |
|---|---|---|
| committer | Éric Araujo <merwok@netwok.org> | 2011-08-02 01:16:12 (GMT) |
| commit | 33af263d36a8a8240989dfb3a0af590681897417 (patch) | |
| tree | 1098452f7ada7cb96597061b1837924ae4a4609f /Misc | |
| parent | 0db7f72cc74baeefaab647cd8f627a0d31becf16 (diff) | |
| download | cpython-33af263d36a8a8240989dfb3a0af590681897417.zip cpython-33af263d36a8a8240989dfb3a0af590681897417.tar.gz cpython-33af263d36a8a8240989dfb3a0af590681897417.tar.bz2 | |
Fix incorrect mtime comparison in distutils (#11933).
This is a regression introduced in 9211a5d7d0b4, when uses of ST_MTIME
constants were changed to uses of st_mtime attributes. As diagnosed in
the bug report, this change is not merely stylistic: st_mtime is a
float but ST_MTIME’s resolution is rounded to the seconds, so there was
a mismatch between the values seen by file_util and dep_util which
caused an sdist to be unnecessarily created a second time on an ext4
filesystem.
This patch has been tested by John S. Gruber, who reported the bug.
As this is a simple code revert, I think it’s okay to commit without a
unit test.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/ACKS | 1 | ||||
| -rw-r--r-- | Misc/NEWS | 2 |
2 files changed, 3 insertions, 0 deletions
@@ -309,6 +309,7 @@ Hans de Graaff Eddy De Greef Duncan Grisby Fabian Groffen +John S. Gruber Dag Gruneau Filip Gruszczyński Michael Guravage @@ -37,6 +37,8 @@ Core and Builtins Library ------- +- Issue #11933: Fix incorrect mtime comparison in distutils. + - Issues #11104, #8688: Fix the behavior of distutils' sdist command with manually-maintained MANIFEST files. |