summaryrefslogtreecommitdiffstats
path: root/Misc
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2012-04-12 22:44:42 (GMT)
committerR David Murray <rdmurray@bitdance.com>2012-04-12 22:44:42 (GMT)
commit51804e9725dd7e727201ba0dffa42db5592c8023 (patch)
tree04631039381f53467bbb40b61a61de9f477b6c01 /Misc
parentd46d69c2796172926296bbc5584551355af4a63a (diff)
downloadcpython-51804e9725dd7e727201ba0dffa42db5592c8023.zip
cpython-51804e9725dd7e727201ba0dffa42db5592c8023.tar.gz
cpython-51804e9725dd7e727201ba0dffa42db5592c8023.tar.bz2
#14399: zipfile now correctly handles comments added to empty zipfiles.
Patch by Serhiy Storchaka. This also moves the TypeError that results from trying to use a unicode comment from the 'close' step to the point at which the comment is added to the zipfile.
Diffstat (limited to 'Misc')
-rw-r--r--Misc/ACKS1
-rw-r--r--Misc/NEWS5
2 files changed, 6 insertions, 0 deletions
diff --git a/Misc/ACKS b/Misc/ACKS
index aab5b20..625689d 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -887,6 +887,7 @@ Richard Stoakley
Peter Stoehr
Casper Stoel
Michael Stone
+Serhiy Storchaka
Ken Stox
Dan Stromberg
Daniel Stutzbach
diff --git a/Misc/NEWS b/Misc/NEWS
index a9fbd8d..5cccc4d 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -39,6 +39,11 @@ Core and Builtins
Library
-------
+- Issue #14399: zipfile now correctly adds a comment even when the zipfile
+ being created is otherwise empty. In addition, the TypeError that results
+ from trying to set a non-binary value as a comment is now now raised at the
+ time the comment is set rather than at the time the zipfile is written.
+
- Issue #7978: socketserver now restarts the select() call when EINTR is
returned. This avoids crashing the server loop when a signal is received.
Patch by Jerzy Kozera.