diff options
| author | Victor Stinner <vstinner@python.org> | 2023-09-08 13:19:20 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-09-08 13:19:20 (GMT) |
| commit | de0202e937ead659d97f0b243fda3db48720c79f (patch) | |
| tree | 5ab44ed23a8a0d172b4ab2250b9bcebcfe66bcac /Misc | |
| parent | 55d7e8fef135a0ce69b0ed19c8b06a4fb04934d1 (diff) | |
| download | cpython-de0202e937ead659d97f0b243fda3db48720c79f.zip cpython-de0202e937ead659d97f0b243fda3db48720c79f.tar.gz cpython-de0202e937ead659d97f0b243fda3db48720c79f.tar.bz2 | |
[3.12] gh-108740: Fix "make regen-all" race condition (#108741) (#109019)
gh-108740: Fix "make regen-all" race condition (#108741)
Fix a race condition in "make regen-all". The deepfreeze.c source and
files generated by Argument Clinic are now generated or updated
before generating "global objects". Previously, some identifiers may
miss depending on the order in which these files were generated.
* "make regen-global-objects": Make sure that deepfreeze.c is
generated and up to date, and always run "make clinic".
* "make clinic" no longer runs generate_global_objects.py script.
* "make regen-deepfreeze" now only updates deepfreeze.c (C file).
It doesn't build deepfreeze.o (object) anymore.
* Remove misleading messages in "make regen-global-objects" and
"make clinic". They are now outdated, these commands are now
safe to use.
* Document generates files in Doc/using/configure.rst.
Co-authored-by: Erlend E. Aasland <erlend@python.org>
(cherry picked from commit db1ee6a19ab62191c16ecb732cb4dcaede98a902)
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst b/Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst new file mode 100644 index 0000000..190d503 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2023-09-01-01-39-26.gh-issue-108740.JHExAQ.rst @@ -0,0 +1,4 @@ +Fix a race condition in ``make regen-all``. The ``deepfreeze.c`` source and +files generated by Argument Clinic are now generated or updated before +generating "global objects". Previously, some identifiers may miss depending +on the order in which these files were generated. Patch by Victor Stinner. |