diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2006-02-07 07:04:46 (GMT) |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2006-02-07 07:04:46 (GMT) |
| commit | 082b2df33f4a916392dca2260fdcdd1cbe3a8329 (patch) | |
| tree | 74534a40daa21d4ca98584ce15a602cf9ef4d260 /Misc | |
| parent | 19cbcad20e3672ffe42e5710843f0df3de3f3b8c (diff) | |
| download | cpython-082b2df33f4a916392dca2260fdcdd1cbe3a8329.zip cpython-082b2df33f4a916392dca2260fdcdd1cbe3a8329.tar.gz cpython-082b2df33f4a916392dca2260fdcdd1cbe3a8329.tar.bz2 | |
Bug #876637, prevent stack corruption when socket descriptor
is larger than FD_SETSIZE.
This can only be acheived with ulimit -n SOME_NUMBER_BIGGER_THAN_FD_SETSIZE
which is typically only available to root. Since this wouldn't normally
be run in a test (ie, run as root), it doesn't seem too worthwhile to
add a normal test. The bug report has one version of a test. I've
written another. Not sure what the best thing to do is.
Do the check before calling internal_select() because we can't set
an error in between Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS.
This seemed the clearest solution, ie handle before calling internal_select()
rather than inside. Plus there is at least one place outside
of internal_select() that needed to be handled.
Will backport.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -216,6 +216,9 @@ Core and builtins Extension Modules ----------------- +- Bug #876637, prevent stack corruption when socket descriptor + is larger than FD_SETSIZE. + - Patch #1407135, bug #1424041: harmonize mmap behavior of anonymous memory. mmap.mmap(-1, size) now returns anonymous memory in both Unix and Windows. mmap.mmap(0, size) should not be used on Windows for anonymous memory. |