diff options
| author | Brett Cannon <bcannon@gmail.com> | 2009-02-10 02:07:38 (GMT) |
|---|---|---|
| committer | Brett Cannon <bcannon@gmail.com> | 2009-02-10 02:07:38 (GMT) |
| commit | 28d108893c5a6663c1747b1c79d0432ba7794e63 (patch) | |
| tree | 5d1379f9d117b038507be68206d60e541898e718 /Misc | |
| parent | 322daea7c3ba7fa73b09ebd50a78078d23d318a5 (diff) | |
| download | cpython-28d108893c5a6663c1747b1c79d0432ba7794e63.zip cpython-28d108893c5a6663c1747b1c79d0432ba7794e63.tar.gz cpython-28d108893c5a6663c1747b1c79d0432ba7794e63.tar.bz2 | |
compileall used the ctime of bytecode and source to determine if the bytecode
should be recreated. This created a timing hole. Fixed by just doing what
import does; check the mtime and magic number.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/ACKS | 3 | ||||
| -rw-r--r-- | Misc/NEWS | 4 |
2 files changed, 6 insertions, 1 deletions
@@ -183,7 +183,7 @@ Virgil Dupras Andy Dustman Gary Duzan Eugene Dvurechenski -Josip Dzolonga +Josip Dzolonga Maxim Dzumanenko Walter Dörwald Hans Eckardt @@ -233,6 +233,7 @@ Peter Funk Geoff Furnish Ulisses Furquim Achim Gaedke +Martin von Gagern Lele Gaifax Santiago Gala Yitzchak Gale @@ -152,6 +152,10 @@ Core and Builtins Library ------- +- Issue #5128: Make compileall properly inspect bytecode to determine if needs + to be recreated. This avoids a timing hole thanks to the old reliance on the + ctime of the files involved. + - Issue #5122: Synchronize tk load failure check to prevent a potential deadlock. |