summaryrefslogtreecommitdiffstats
path: root/Misc
diff options
context:
space:
mode:
authorChristian Heimes <christian@cheimes.de>2012-09-11 13:47:28 (GMT)
committerChristian Heimes <christian@cheimes.de>2012-09-11 13:47:28 (GMT)
commit6d29352cfd76d569198dd2fd2eb02b2b0c5a8c44 (patch)
tree1f678f6a727009c0ee8d9ba1d2fd5817fecd25fb /Misc
parent6a77af690fc5022ecd218771960d15af2dc74977 (diff)
downloadcpython-6d29352cfd76d569198dd2fd2eb02b2b0c5a8c44.zip
cpython-6d29352cfd76d569198dd2fd2eb02b2b0c5a8c44.tar.gz
cpython-6d29352cfd76d569198dd2fd2eb02b2b0c5a8c44.tar.bz2
Issue #15895: my analysis was slightly off. The FILE pointer is only leaked when set_main_loader() fails for a pyc file with closeit=0. In the success case run_pyc_file() does its own cleanup of the fp. I've changed the code to use another FILE ptr for pyc files and moved the fclose() to PyRun_SimpleFileExFlags() to make it more obvious what's happening.
Diffstat (limited to 'Misc')
-rw-r--r--Misc/NEWS3
1 files changed, 2 insertions, 1 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 068c4b1..0fe95da 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,7 +10,8 @@ What's New in Python 3.3.1
Core and Builtins
-----------------
-- Issue #15895: Fix FILE pointer leak in PyRun_SimpleFileExFlags() when
+- Issue #15895: Fix FILE pointer leak in one error branch of
+ PyRun_SimpleFileExFlags() when
filename points to a pyc/pyo file and closeit is false.
- Issue #15900: Fix reference leak in PyUnicode_TranslateCharmap().