diff options
| author | Victor Stinner <vstinner@python.org> | 2019-12-11 10:30:03 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-11 10:30:03 (GMT) |
| commit | 0d63bacefd2e5b937ec6b0ec3053777c09941b4a (patch) | |
| tree | 638bde819a554379c8c5aff31ba8d6a1feeb1db1 /Misc | |
| parent | b7a0109cd2bafaa21a4d50aad307e901c68f9156 (diff) | |
| download | cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.zip cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.gz cpython-0d63bacefd2e5b937ec6b0ec3053777c09941b4a.tar.bz2 | |
bpo-38614: Use test.support.SHORT_TIMEOUT constant (GH-17566)
Replace hardcoded timeout constants in tests with SHORT_TIMEOUT of
test.support, so it's easier to ajdust this timeout for all tests at
once.
SHORT_TIMEOUT is 30 seconds by default, but it can be longer
depending on --timeout command line option.
The change makes almost all timeouts longer, except
test_reap_children() of test_support which is made 2x shorter:
SHORT_TIMEOUT should be enough. If this test starts to fail,
LONG_TIMEOUT should be used instead.
Uniformize also "from test import support" import in some test files.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS.d/next/Tests/2019-12-10-14-26-23.bpo-38614.89JpNh.rst | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/Misc/NEWS.d/next/Tests/2019-12-10-14-26-23.bpo-38614.89JpNh.rst b/Misc/NEWS.d/next/Tests/2019-12-10-14-26-23.bpo-38614.89JpNh.rst index df20f48..102563f 100644 --- a/Misc/NEWS.d/next/Tests/2019-12-10-14-26-23.bpo-38614.89JpNh.rst +++ b/Misc/NEWS.d/next/Tests/2019-12-10-14-26-23.bpo-38614.89JpNh.rst @@ -1,3 +1,6 @@ Replace hardcoded timeout constants in tests with -:data:`~test.support.LOOPBACK_TIMEOUT` of :mod:`test.support`, so it's easier -to ajdust this timeout for all tests at once. +new :mod:`test.support` constants: :data:`~test.support.LOOPBACK_TIMEOUT`, +:data:`~test.support.INTERNET_TIMEOUT`, :data:`~test.support.SHORT_TIMEOUT` and +:data:`~test.support.LONG_TIMEOUT`. It becomes easier to adjust these four +timeout constants for all tests at once, rather than having to adjust every +single test file. |