summaryrefslogtreecommitdiffstats
path: root/Misc
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2013-12-27 16:24:32 (GMT)
committerR David Murray <rdmurray@bitdance.com>2013-12-27 16:24:32 (GMT)
commitecff5e51a5c65037103c23c937a02184050b7117 (patch)
treefa5bf717b4756d992b8205852f40055d6f635833 /Misc
parent5eb01530b2bfba81b09e5129caabeada2d8dc487 (diff)
downloadcpython-ecff5e51a5c65037103c23c937a02184050b7117.zip
cpython-ecff5e51a5c65037103c23c937a02184050b7117.tar.gz
cpython-ecff5e51a5c65037103c23c937a02184050b7117.tar.bz2
#18116: backport fix to 3.3 since real-world failure mode demonstrated.
In issue 20074 it was pointed out that getpass would fail with a traceback if stdin was, for example /dev/null, which is a non-unlikely scenario. Also backported the tests from issue 17484 as modified by issue 18116. (What I really did was copy getpass.py and test_getpass.py from their state on tip as of 17bd04fbf3d3).
Diffstat (limited to 'Misc')
-rw-r--r--Misc/NEWS5
1 files changed, 5 insertions, 0 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 85b5354..bc0e0b4 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -29,6 +29,11 @@ Core and Builtins
Library
-------
+- Issue #18116: getpass was always getting an error when testing /dev/tty,
+ and thus was always falling back to stdin, and would then raise an exception
+ if stdin could not be used (such as /dev/null). It also leaked an open file.
+ All of these issues are now fixed.
+
- Issue #20027: Fixed locale aliases for devanagari locales.
- Issue #20067: Tkinter variables now work when wantobjects is false.