diff options
| author | R David Murray <rdmurray@bitdance.com> | 2013-03-19 17:52:33 (GMT) |
|---|---|---|
| committer | R David Murray <rdmurray@bitdance.com> | 2013-03-19 17:52:33 (GMT) |
| commit | fcb6d6a3b3bfba67927ced18dd648ba889e14f4c (patch) | |
| tree | 2fd07ed3bc58201cfb53ad8046c83a80bdec4bd4 /Misc | |
| parent | ae4ef4d2ff2d49628516294837249493f43a5047 (diff) | |
| download | cpython-fcb6d6a3b3bfba67927ced18dd648ba889e14f4c.zip cpython-fcb6d6a3b3bfba67927ced18dd648ba889e14f4c.tar.gz cpython-fcb6d6a3b3bfba67927ced18dd648ba889e14f4c.tar.bz2 | |
#17443: Fix buffering in IMAP4_stream.
In Python2 Popen uses *FILE objects, which wind up buffering even though
subprocess defaults to no buffering. In Python3, subprocess streams really
are unbuffered by default, but the imaplib code assumes read is buffered. This
patch uses the default buffer size from the io module to get buffered streams
from Popen.
Much debugging work and patch by Diane Trout.
The imap protocol is too complicated to write a test for this simple
change with our current level of test infrastructure.
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/ACKS | 1 | ||||
| -rw-r--r-- | Misc/NEWS | 4 |
2 files changed, 5 insertions, 0 deletions
@@ -1098,6 +1098,7 @@ Richard Townsend Nathan Trapuzzano Laurence Tratt John Tromp +Diane Trout Jason Trowbridge Brent Tubbs Anthony Tuininga @@ -233,6 +233,10 @@ Core and Builtins Library ------- +- Issue #17443: impalib.IMAP4_stream was using the default unbuffered IO + in subprocess, but the imap code assumes buffered IO. In Python2 this + worked by accident. IMAP4_stream now explicitly uses buffered IO. + - Issue #17476: Fixed regression relative to Python2 in undocumented pydoc 'allmethods'; it was missing unbound methods on the class. |