diff options
| author | Michael W. Hudson <mwh@python.net> | 2005-03-31 10:20:34 (GMT) |
|---|---|---|
| committer | Michael W. Hudson <mwh@python.net> | 2005-03-31 10:20:34 (GMT) |
| commit | 59f9bea8738b5811650c53961d9a6036c3b9bcbe (patch) | |
| tree | 5a0cde3ac414dfd4a1c746e3db79dd297e7a81a7 /Misc | |
| parent | 4cf27049b68a2c1dca643638f319966ba3fae4ee (diff) | |
| download | cpython-59f9bea8738b5811650c53961d9a6036c3b9bcbe.zip cpython-59f9bea8738b5811650c53961d9a6036c3b9bcbe.tar.gz cpython-59f9bea8738b5811650c53961d9a6036c3b9bcbe.tar.bz2 | |
Backport:
Fixes for
[ 1166660 ] The readline module can cause python to segfault
It seems to me that the code I'm rewriting here attempted to call any
user-supplied hook functions using the thread state of the thread that
called the hook-setting function, as opposed to that of the thread
that is currently executing. This doesn't work, in general.
Fix this by using the PyGILState API (It wouldn't be that hard to
define a dummy version of said API when #ifndef WITH_THREAD, would
it?).
Also, check the conversion to integer of the return value of a hook
function for errors (this problem was mentioned in the ipython bug
report linked to in the above bug).
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -10,6 +10,9 @@ What's New in Python 2.4.2a Extension Modules ----------------- +- Bug #1166660: The readline module could segfault if hook functions + were set in a different thread than that which called readline. + - weakref proxy has incorrect __nonzero__ behavior. SF bug #1770766. |