diff options
author | Martin v. Löwis <martin@v.loewis.de> | 2006-05-27 08:54:29 (GMT) |
---|---|---|
committer | Martin v. Löwis <martin@v.loewis.de> | 2006-05-27 08:54:29 (GMT) |
commit | d532ba07469d60866df60ec4a2f8afe714347d66 (patch) | |
tree | fff97c833e3aed3b3df5c39bf127fb3e96c56287 /Modules/_codecsmodule.c | |
parent | d004fc810af3e1985686e616763e14a1b0aa60c1 (diff) | |
download | cpython-d532ba07469d60866df60ec4a2f8afe714347d66.zip cpython-d532ba07469d60866df60ec4a2f8afe714347d66.tar.gz cpython-d532ba07469d60866df60ec4a2f8afe714347d66.tar.bz2 |
Explain why 'consumed' is initialized.
Diffstat (limited to 'Modules/_codecsmodule.c')
-rw-r--r-- | Modules/_codecsmodule.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/Modules/_codecsmodule.c b/Modules/_codecsmodule.c index 26bc2cb..d8d23c4 100644 --- a/Modules/_codecsmodule.c +++ b/Modules/_codecsmodule.c @@ -319,12 +319,11 @@ utf_16_decode(PyObject *self, if (!PyArg_ParseTuple(args, "t#|zi:utf_16_decode", &data, &size, &errors, &final)) return NULL; - /* XXX Why is consumed initialized to size? mvl */ if (size < 0) { PyErr_SetString(PyExc_ValueError, "negative argument"); return 0; } - consumed = size; + consumed = size; /* This is overwritten unless final is true. */ decoded = PyUnicode_DecodeUTF16Stateful(data, size, errors, &byteorder, final ? NULL : &consumed); if (decoded == NULL) @@ -348,12 +347,11 @@ utf_16_le_decode(PyObject *self, &data, &size, &errors, &final)) return NULL; - /* XXX Why is consumed initialized to size? mvl */ if (size < 0) { PyErr_SetString(PyExc_ValueError, "negative argument"); return 0; } - consumed = size; + consumed = size; /* This is overwritten unless final is true. */ decoded = PyUnicode_DecodeUTF16Stateful(data, size, errors, &byteorder, final ? NULL : &consumed); if (decoded == NULL) @@ -377,12 +375,11 @@ utf_16_be_decode(PyObject *self, if (!PyArg_ParseTuple(args, "t#|zi:utf_16_be_decode", &data, &size, &errors, &final)) return NULL; - /* XXX Why is consumed initialized to size? mvl */ if (size < 0) { PyErr_SetString(PyExc_ValueError, "negative argument"); return 0; } - consumed = size; + consumed = size; /* This is overwritten unless final is true. */ decoded = PyUnicode_DecodeUTF16Stateful(data, size, errors, &byteorder, final ? NULL : &consumed); if (decoded == NULL) @@ -413,12 +410,11 @@ utf_16_ex_decode(PyObject *self, if (!PyArg_ParseTuple(args, "t#|zii:utf_16_ex_decode", &data, &size, &errors, &byteorder, &final)) return NULL; - /* XXX Why is consumed initialized to size? mvl */ if (size < 0) { PyErr_SetString(PyExc_ValueError, "negative argument"); return 0; } - consumed = size; + consumed = size; /* This is overwritten unless final is true. */ unicode = PyUnicode_DecodeUTF16Stateful(data, size, errors, &byteorder, final ? NULL : &consumed); if (unicode == NULL) |