diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2016-12-09 14:39:28 (GMT) |
|---|---|---|
| committer | Victor Stinner <victor.stinner@gmail.com> | 2016-12-09 14:39:28 (GMT) |
| commit | 61bdb0d31924ec5fd12aa8dbe197002c57dfbf82 (patch) | |
| tree | 8b2b7b6564c1997cea13060a769ddc56240f45c0 /Modules/_io/winconsoleio.c | |
| parent | 20401deae219ed38e8a7e9f960ef3b0dc3850dce (diff) | |
| download | cpython-61bdb0d31924ec5fd12aa8dbe197002c57dfbf82.zip cpython-61bdb0d31924ec5fd12aa8dbe197002c57dfbf82.tar.gz cpython-61bdb0d31924ec5fd12aa8dbe197002c57dfbf82.tar.bz2 | |
Use _PyObject_CallMethodIdObjArgs() in _io
Issue #28915: Replace _PyObject_CallMethodId() with
_PyObject_CallMethodIdObjArgs() when the format string was only made of "O"
formats, PyObject* arguments.
_PyObject_CallMethodIdObjArgs() avoids the creation of a temporary tuple and
doesn't have to parse a format string.
Diffstat (limited to 'Modules/_io/winconsoleio.c')
| -rw-r--r-- | Modules/_io/winconsoleio.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c index 7b00a9e..d8e4339 100644 --- a/Modules/_io/winconsoleio.c +++ b/Modules/_io/winconsoleio.c @@ -85,7 +85,7 @@ char _PyIO_get_console_type(PyObject *path_or_fd) { Py_CLEAR(decoded); return '\0'; } - decoded_upper = PyObject_CallMethod(decoded, "upper", ""); + decoded_upper = PyObject_CallMethod(decoded, "upper", NULL); Py_CLEAR(decoded); if (!decoded_upper) { PyErr_Clear(); @@ -181,8 +181,8 @@ _io__WindowsConsoleIO_close_impl(winconsoleio *self) PyObject *exc, *val, *tb; int rc; _Py_IDENTIFIER(close); - res = _PyObject_CallMethodId((PyObject*)&PyRawIOBase_Type, - &PyId_close, "O", self); + res = _PyObject_CallMethodIdObjArgs((PyObject*)&PyRawIOBase_Type, + &PyId_close, self, NULL); if (!self->closehandle) { self->handle = INVALID_HANDLE_VALUE; return res; |
