diff options
author | Serhiy Storchaka <storchaka@gmail.com> | 2016-11-16 08:19:57 (GMT) |
---|---|---|
committer | Serhiy Storchaka <storchaka@gmail.com> | 2016-11-16 08:19:57 (GMT) |
commit | 1a73bf365e9664f8dd3357ebbb78ceaa79df2172 (patch) | |
tree | 87917a1a572c2f3c5a574d6a96a9879970a941d9 /Modules/_io | |
parent | 1e2784e0b3cb8d9050bffb338b2de838fbba13a2 (diff) | |
parent | 3b73ea127892d0e1f9d8f12f88e4f9c0ba0b89b1 (diff) | |
download | cpython-1a73bf365e9664f8dd3357ebbb78ceaa79df2172.zip cpython-1a73bf365e9664f8dd3357ebbb78ceaa79df2172.tar.gz cpython-1a73bf365e9664f8dd3357ebbb78ceaa79df2172.tar.bz2 |
Issue #28701: Replace PyUnicode_CompareWithASCIIString with _PyUnicode_EqualToASCIIString.
The latter function is more readable, faster and doesn't raise exceptions.
Diffstat (limited to 'Modules/_io')
-rw-r--r-- | Modules/_io/textio.c | 2 | ||||
-rw-r--r-- | Modules/_io/winconsoleio.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c index dca4ea9..2f55eb0 100644 --- a/Modules/_io/textio.c +++ b/Modules/_io/textio.c @@ -1023,7 +1023,7 @@ _io_TextIOWrapper___init___impl(textio *self, PyObject *buffer, else if (PyUnicode_Check(res)) { const encodefuncentry *e = encodefuncs; while (e->name != NULL) { - if (!PyUnicode_CompareWithASCIIString(res, e->name)) { + if (_PyUnicode_EqualToASCIIString(res, e->name)) { self->encodefunc = e->encodefunc; break; } diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c index 4666a38..7b00a9e 100644 --- a/Modules/_io/winconsoleio.c +++ b/Modules/_io/winconsoleio.c @@ -93,11 +93,11 @@ char _PyIO_get_console_type(PyObject *path_or_fd) { } char m = '\0'; - if (PyUnicode_CompareWithASCIIString(decoded_upper, "CONIN$") == 0) { + if (_PyUnicode_EqualToASCIIString(decoded_upper, "CONIN$")) { m = 'r'; - } else if (PyUnicode_CompareWithASCIIString(decoded_upper, "CONOUT$") == 0) { + } else if (_PyUnicode_EqualToASCIIString(decoded_upper, "CONOUT$")) { m = 'w'; - } else if (PyUnicode_CompareWithASCIIString(decoded_upper, "CON") == 0) { + } else if (_PyUnicode_EqualToASCIIString(decoded_upper, "CON")) { m = 'x'; } |