diff options
author | Nathaniel J. Smith <njs@pobox.com> | 2017-05-16 21:12:11 (GMT) |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2017-05-16 21:12:11 (GMT) |
commit | 4ae01496971624c75080431806ed1c08e00f22c7 (patch) | |
tree | 158ab0632954342f129f74f99d0a09cc4142a5d9 /Modules/_math.c | |
parent | fca224f117d25bdfec1bf7160b67438c4fcf6dee (diff) | |
download | cpython-4ae01496971624c75080431806ed1c08e00f22c7.zip cpython-4ae01496971624c75080431806ed1c08e00f22c7.tar.gz cpython-4ae01496971624c75080431806ed1c08e00f22c7.tar.bz2 |
bpo-30038: fix race condition in signal delivery + wakeup fd (#1082)
Before, it was possible to get the following sequence of
events (especially on Windows, where the C-level signal handler for
SIGINT is run in a separate thread):
- SIGINT arrives
- trip_signal is called
- trip_signal writes to the wakeup fd
- the main thread wakes up from select()-or-equivalent
- the main thread checks for pending signals, but doesn't see any
- the main thread drains the wakeup fd
- the main thread goes back to sleep
- trip_signal sets is_tripped=1 and calls Py_AddPendingCall to notify
the main thread the it should run the Python-level signal handler
- the main thread doesn't notice because it's asleep
This has been causing repeated failures in the Trio test suite:
https://github.com/python-trio/trio/issues/119
Diffstat (limited to 'Modules/_math.c')
0 files changed, 0 insertions, 0 deletions